RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 21:27:35 +00:00
Code Issues Activity Actions

LibWeb: Use LineBox::height() when determining IFC auto heights

Browse source 
We don't need to loop through all the fragments on the line to work out
how tall it is. Just ask for the height. :^)
This commit is contained in:
Andreas Kling 2022-03-28 21:04:21 +02:00
parent d6ce3e63e2
commit 5def3b0150
1 changed files with 1 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

7
Userland/Libraries/LibWeb/Layout/InlineFormattingContext.cpp
View file

@ -69,17 +69,12 @@ void InlineFormattingContext::run(Box const&, LayoutMode layout_mode)
generate_line_boxes(layout_mode); generate_line_boxes(layout_mode);
float min_line_height = containing_block().line_height();
float max_line_width = 0; float max_line_width = 0;
float content_height = 0; float content_height = 0;
for (auto& line_box : m_state.get(containing_block()).line_boxes) { for (auto& line_box : m_state.get(containing_block()).line_boxes) {
float max_height = min_line_height;
for (auto& fragment : line_box.fragments()) {
max_height = max(max_height, fragment.border_box_height());
}
max_line_width = max(max_line_width, line_box.width()); max_line_width = max(max_line_width, line_box.width());
content_height += max_height; content_height += line_box.height();
} }
auto& containing_block_state = m_state.get_mutable(containing_block()); auto& containing_block_state = m_state.get_mutable(containing_block());