1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-14 08:34:57 +00:00

Ladybird: Add the select-all action to the JS console

Also clarify a comment, because it wasn't immediately clear to me what
wouldn't work without the code below it.
This commit is contained in:
Timothy Flynn 2023-08-08 18:23:01 -04:00 committed by Andreas Kling
parent 59b583329a
commit 601da7e5bd

View file

@ -665,12 +665,15 @@ void Tab::show_console_window()
m_console_widget->setWindowTitle("JS Console");
m_console_widget->resize(640, 480);
// Make the copy action available in the window via the bound copy key shortcut.
// Simply adding it to the context menu is not enough.
// Make these actions available on the window itself. Adding them to the context menu alone
// does not enable activattion via keyboard shortcuts.
m_console_widget->addAction(&m_window->copy_selection_action());
m_console_widget->addAction(&m_window->select_all_action());
m_console_context_menu = make<QMenu>("Context menu", m_console_widget);
m_console_context_menu->addAction(&m_window->copy_selection_action());
m_console_context_menu->addAction(&m_window->select_all_action());
m_console_widget->view().on_context_menu_request = [this](Gfx::IntPoint) {
auto screen_position = QCursor::pos();
m_console_context_menu->exec(screen_position);