RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-31 09:48:11 +00:00
Code Issues Activity Actions

LibHTML: Only actually-linked <a> elements should be blue+underlined

Browse source 
Turns out this just needed a little push in the selector engine. :^)
This commit is contained in:
Andreas Kling 2019-10-20 09:18:46 +02:00
parent c41bae3d54
commit 64ce453050
2 changed files with 3 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Libraries/LibHTML/CSS/Default.css
View file

@ -89,7 +89,7 @@ li {
margin-bottom: 2; margin-bottom: 2;
} }
a { a:link {
color: -libhtml-link; color: -libhtml-link;
text-decoration: underline; text-decoration: underline;
} }

3
Libraries/LibHTML/CSS/SelectorEngine.cpp
View file

@ -20,7 +20,8 @@ bool matches(const Selector::Component& component, const Element& element)
case Selector::Component::PseudoClass::None: case Selector::Component::PseudoClass::None:
break; break;
case Selector::Component::PseudoClass::Link: case Selector::Component::PseudoClass::Link:
ASSERT_NOT_REACHED(); if (!element.is_link())
return false;
break; break;
case Selector::Component::PseudoClass::Hover: case Selector::Component::PseudoClass::Hover:
if (!matches_hover_pseudo_class(element)) if (!matches_hover_pseudo_class(element))