RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-30 23:58:12 +00:00
Code Issues Activity Actions

LibWeb: Grey out invisible nodes in the DOM inspector

Browse source 
This makes it easier to navigate large DOM trees where
some nodes have display: none
This commit is contained in:
Simon Wanner 2022-03-20 19:11:03 +01:00 • committed by Andreas Kling
parent a128d4931d
commit 69fc7009bf
2 changed files with 4 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Userland/Libraries/LibWeb/DOM/Node.cpp
View file

@ -793,6 +793,8 @@ void Node::serialize_tree_as_json(JsonObjectSerializer<StringBuilder>& object) c
MUST(object.add("data"sv, static_cast<DOM::Comment const&>(*this).data())); MUST(object.add("data"sv, static_cast<DOM::Comment const&>(*this).data()));
} }
MUST((object.add("visible"sv, !!layout_node())));
if (has_child_nodes()) { if (has_child_nodes()) {
auto children = MUST(object.add_array("children")); auto children = MUST(object.add_array("children"));
for_each_child([&children](DOM::Node& child) { for_each_child([&children](DOM::Node& child) {

2
Userland/Libraries/LibWeb/DOMTreeModel.cpp
View file

@ -126,6 +126,8 @@ GUI::Variant DOMTreeModel::data(const GUI::ModelIndex& index, GUI::ModelRole rol
return m_tree_view.palette().syntax_comment(); return m_tree_view.palette().syntax_comment();
if (type == "pseudo-element"sv) if (type == "pseudo-element"sv)
return m_tree_view.palette().syntax_type(); return m_tree_view.palette().syntax_type();
if (!node.get("visible").to_bool(true))
return m_tree_view.palette().syntax_comment();
return {}; return {};
} }