RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 15:47:44 +00:00
Code Issues Activity Actions

LibWeb: Properly copy method and headers from the input in Request()

Browse source 
We were accidentally copying these from the newly created Request
object's underlying request, to itself. Thanks to Lubrsi for catching
this!

Co-authored-by: Luke Wilde <lukew@serenityos.org>
This commit is contained in:
Linus Groh 2022-11-04 21:20:46 +00:00
parent 71228a8d86
commit 6cd57d4c15
1 changed files with 2 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

4
Userland/Libraries/LibWeb/Fetch/Request.cpp
View file

@ -174,12 +174,12 @@ WebIDL::ExceptionOr<JS::NonnullGCPtr<Request>> Request::construct_impl(JS::Realm
// method
// request’s method.
request->set_method(TRY_OR_RETURN_OOM(realm, ByteBuffer::copy(request->method())));
request->set_method(TRY_OR_RETURN_OOM(realm, ByteBuffer::copy(input_request->method())));
// header list
// A copy of request’s header list.
auto header_list_copy = Infrastructure::HeaderList::create(vm);
for (auto& header : *request->header_list())
for (auto& header : *input_request->header_list())
TRY_OR_RETURN_OOM(realm, header_list_copy->append(header));
request->set_header_list(header_list_copy);