RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 07:47:37 +00:00
Code Issues Activity Actions

LibJS: Only allow TimeZone this value in Temporal.TimeZone#toJSON

Browse source 
This is a normative change in the Temporal spec.

See: 2644fc6
This commit is contained in:
Luke Wilde 2021-12-18 23:06:32 +00:00 • committed by Linus Groh
parent 6c8c34ed6c
commit 7729598b5b
2 changed files with 10 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

7
Userland/Libraries/LibJS/Runtime/Temporal/TimeZonePrototype.cpp
View file

@ -230,10 +230,11 @@ JS_DEFINE_NATIVE_FUNCTION(TimeZonePrototype::to_string)
JS_DEFINE_NATIVE_FUNCTION(TimeZonePrototype::to_json) JS_DEFINE_NATIVE_FUNCTION(TimeZonePrototype::to_json)
{ {
// 1. Let timeZone be the this value. // 1. Let timeZone be the this value.
auto time_zone = vm.this_value(global_object); // 2. Perform ? RequireInternalSlot(timeZone, [[InitializedTemporalTimeZone]]).
auto* time_zone = TRY(typed_this_object(global_object));
// 2. Return ? ToString(timeZone). // 3. Return ? ToString(timeZone).
return js_string(vm, TRY(time_zone.to_string(global_object))); return js_string(vm, TRY(Value(time_zone).to_string(global_object)));
} }
} }

8
Userland/Libraries/LibJS/Tests/builtins/Temporal/TimeZone/TimeZone.prototype.toJSON.js
View file

@ -7,8 +7,12 @@ describe("correct behavior", () => {
const timeZone = new Temporal.TimeZone("UTC"); const timeZone = new Temporal.TimeZone("UTC");
expect(timeZone.toJSON()).toBe("UTC"); expect(timeZone.toJSON()).toBe("UTC");
}); });
});
test("works with any this value", () => { describe("errors", () => {
expect(Temporal.TimeZone.prototype.toJSON.call("foo")).toBe("foo"); test("this value must be a Temporal.TimeZone object", () => {
expect(() => {
Temporal.TimeZone.prototype.toJSON.call("foo");
}).toThrowWithMessage(TypeError, "Not an object of type Temporal.TimeZone");
}); });
}); });