RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-10-31 15:12:45 +00:00
Code Issues Activity Actions

NotificationServer: Remove unnecessary greet() message

Browse source
This commit is contained in:
Andreas Kling 2021-05-23 09:21:26 +02:00
parent 5424372d50
commit 78b57fcea3
4 changed files with 0 additions and 9 deletions
Download patch file Download diff file Expand all files Collapse all files

1
Userland/Libraries/LibGUI/Notification.cpp
View file

@ -20,7 +20,6 @@ class NotificationServerConnection : public IPC::ServerConnection<NotificationCl
public: public:
virtual void handshake() override virtual void handshake() override
{ {
greet();
} }
virtual void die() override virtual void die() override

4
Userland/Services/NotificationServer/ClientConnection.cpp
View file

@ -28,10 +28,6 @@ void ClientConnection::die()
s_connections.remove(client_id()); s_connections.remove(client_id());
} }
void ClientConnection::greet()
{
}
void ClientConnection::show_notification(String const& text, String const& title, Gfx::ShareableBitmap const& icon) void ClientConnection::show_notification(String const& text, String const& title, Gfx::ShareableBitmap const& icon)
{ {
auto window = NotificationWindow::construct(client_id(), text, title, icon); auto window = NotificationWindow::construct(client_id(), text, title, icon);

1
Userland/Services/NotificationServer/ClientConnection.h
View file

@ -22,7 +22,6 @@ public:
private: private:
explicit ClientConnection(NonnullRefPtr<Core::LocalSocket>, int client_id); explicit ClientConnection(NonnullRefPtr<Core::LocalSocket>, int client_id);
virtual void greet() override;
virtual void show_notification(String const&, String const&, Gfx::ShareableBitmap const&) override; virtual void show_notification(String const&, String const&, Gfx::ShareableBitmap const&) override;
virtual void close_notification() override; virtual void close_notification() override;
virtual Messages::NotificationServer::UpdateNotificationIconResponse update_notification_icon(Gfx::ShareableBitmap const&) override; virtual Messages::NotificationServer::UpdateNotificationIconResponse update_notification_icon(Gfx::ShareableBitmap const&) override;

3
Userland/Services/NotificationServer/NotificationServer.ipc
View file

@ -1,8 +1,5 @@
endpoint NotificationServer endpoint NotificationServer
{ {
// Basic protocol
greet() => ()
show_notification([UTF8] String text, [UTF8] String title, Gfx::ShareableBitmap icon) => () show_notification([UTF8] String text, [UTF8] String title, Gfx::ShareableBitmap icon) => ()
update_notification_text([UTF8] String text, [UTF8] String title) => (bool still_showing) update_notification_text([UTF8] String text, [UTF8] String title) => (bool still_showing)