RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 22:07:35 +00:00
Code Issues Activity Actions

LibWeb: Use Window::scroll() in Element::set_scroll_top()

Browse source 
Now when Window::scroll() could do actual scrolling we can remove
this FIXME.
This commit is contained in:
Aliaksandr Kalenik 2024-02-01 14:50:53 +01:00 • committed by Tim Flynn
parent a4d78c7df9
commit 79b73b7fbb
1 changed files with 2 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

8
Userland/Libraries/LibWeb/DOM/Element.cpp
View file

@ -1299,17 +1299,13 @@ void Element::set_scroll_top(double y)
// 8. If the element is the root element invoke scroll() on window with scrollX on window as first argument and y as second argument, and terminate these steps.
if (document.document_element() == this) {
// FIXME: Implement this in terms of invoking scroll() on window.
if (document.browsing_context() == &document.page().top_level_browsing_context())
document.page().client().page_did_request_scroll_to({ static_cast<float>(window->scroll_x()), static_cast<float>(y) });
window->scroll(window->scroll_x(), y);
return;
}
// 9. If the element is the body element, document is in quirks mode, and the element is not potentially scrollable, invoke scroll() on window with scrollX as first argument and y as second argument, and terminate these steps.
if (document.body() == this && document.in_quirks_mode() && !is_potentially_scrollable()) {
// FIXME: Implement this in terms of invoking scroll() on window.
if (document.browsing_context() == &document.page().top_level_browsing_context())
document.page().client().page_did_request_scroll_to({ static_cast<float>(window->scroll_x()), static_cast<float>(y) });
window->scroll(window->scroll_x(), y);
return;
}