RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-31 07:18:11 +00:00
Code Issues Activity Actions

LibGUI: Model-less views should not swallow key events

Browse source 
At least pass them up to GUI::Widget so they can be handled there.
This commit is contained in:
Andreas Kling 2020-10-28 21:21:50 +01:00
parent b5bd05b717
commit 80e12999c4
3 changed files with 3 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Libraries/LibGUI/ListView.cpp
View file

@ -196,7 +196,7 @@ void ListView::mousemove_event(MouseEvent& event)
void ListView::keydown_event(KeyEvent& event) void ListView::keydown_event(KeyEvent& event)
{ {
if (!model()) if (!model())
return; return AbstractView::keydown_event(event);
if (event.key() == KeyCode::Key_Escape) { if (event.key() == KeyCode::Key_Escape) {
if (on_escape_pressed) if (on_escape_pressed)

2
Libraries/LibGUI/TableView.cpp
View file

@ -170,7 +170,7 @@ void TableView::paint_event(PaintEvent& event)
void TableView::keydown_event(KeyEvent& event) void TableView::keydown_event(KeyEvent& event)
{ {
if (!model()) if (!model())
return; return AbstractTableView::keydown_event(event);
AbstractTableView::keydown_event(event); AbstractTableView::keydown_event(event);

2
Libraries/LibGUI/TreeView.cpp
View file

@ -433,7 +433,7 @@ void TreeView::did_update_selection()
void TreeView::keydown_event(KeyEvent& event) void TreeView::keydown_event(KeyEvent& event)
{ {
if (!model()) if (!model())
return; return AbstractTableView::keydown_event(event);
if (event.key() == KeyCode::Key_Space) { if (event.key() == KeyCode::Key_Space) {
if (model()->row_count(cursor_index())) if (model()->row_count(cursor_index()))