RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-31 14:28:12 +00:00
Code Issues Activity Actions

headless-browser: Don't choke on subframe load completions

Browse source 
This didn't break any existing tests, but I have to do this for an
upcoming test to not bring everything down.
This commit is contained in:
Andreas Kling 2024-02-23 17:06:32 +01:00
parent 9759f44faf
commit 8586897928
1 changed files with 3 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

4
Userland/Utilities/headless-browser.cpp
View file

@ -303,7 +303,9 @@ static ErrorOr<TestResult> run_dump_test(HeadlessWebContentView& view, StringVie
} else if (mode == TestMode::Text) { } else if (mode == TestMode::Text) {
view.on_load_finish = [&](auto const& loaded_url) { view.on_load_finish = [&](auto const& loaded_url) {
VERIFY(url.equals(loaded_url, URL::ExcludeFragment::Yes)); // NOTE: We don't want subframe loads to trigger the test finish.
if (!url.equals(loaded_url, URL::ExcludeFragment::Yes))
return;
did_finish_loading = true; did_finish_loading = true;
if (did_finish_test) if (did_finish_test)
loop.quit(0); loop.quit(0);