RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 19:37:35 +00:00
Code Issues Activity Actions

JSSpecCompiler: Parse arbitrarily large rational numbers in xspec mode

Browse source
This commit is contained in:
Dan Klishch 2024-01-20 21:18:05 -05:00 • committed by Andrew Kaster
parent 2a2e31f2ed
commit 86d54a8684
9 changed files with 64 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

3
Meta/Lagom/Tools/CodeGenerators/JSSpecCompiler/Parser/CppASTConverter.cpp
View file

@ -126,7 +126,8 @@ template<>
NullableTree CppASTConverter::convert_node(Cpp::NumericLiteral const& literal)
{
// TODO: Numerical literals are not limited to i64.
return make_ref_counted<MathematicalConstant>(literal.value().to_number<i64>().value());
VERIFY(literal.value().to_number<i64>().has_value());
return make_ref_counted<MathematicalConstant>(MUST(Crypto::BigFraction::from_string(literal.value())));
}
template<>

2
Meta/Lagom/Tools/CodeGenerators/JSSpecCompiler/Parser/TextParser.cpp
View file

@ -299,7 +299,7 @@ TextParseErrorOr<Tree> TextParser::parse_expression()
if (token.type == TokenType::Identifier) {
expression = make_ref_counted<UnresolvedReference>(token.data);
} else if (token.type == TokenType::Number) {
expression = make_ref_counted<MathematicalConstant>(token.data.to_number<i64>().value());
expression = make_ref_counted<MathematicalConstant>(MUST(Crypto::BigFraction::from_string(token.data)));
} else if (token.type == TokenType::String) {
expression = make_ref_counted<StringLiteral>(token.data);
} else {