RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 19:27:45 +00:00
Code Issues Activity Actions

LibJS: Replace enumeration macro in typed_array_species_create()

Browse source 
Use the newly added TypedArrayBase::intrinsic_constructor() instead to
get the required constructor from the global object.

Also add spec comments while we're here.
This commit is contained in:
Linus Groh 2022-06-26 13:32:15 +01:00
parent 3885fa1d10
commit 893978ea89
1 changed files with 8 additions and 11 deletions
Download patch file Download diff file Expand all files Collapse all files

19
Userland/Libraries/LibJS/Runtime/TypedArrayPrototype.cpp
View file

@ -141,24 +141,21 @@ static ThrowCompletionOr<TypedArrayBase*> typed_array_species_create(GlobalObjec
{ {
auto& vm = global_object.vm(); auto& vm = global_object.vm();
TypedArrayConstructor* typed_array_default_constructor = nullptr; // 1. Let defaultConstructor be the intrinsic object listed in column one of Table 72 for exemplar.[[TypedArrayName]].
auto* default_constructor = (global_object.*exemplar.intrinsic_constructor())();
// FIXME: This kinda sucks. // 2. Let constructor be ? SpeciesConstructor(exemplar, defaultConstructor).
#define __JS_ENUMERATE(ClassName, snake_name, PrototypeName, ConstructorName, Type) \ auto* constructor = TRY(species_constructor(global_object, exemplar, *default_constructor));
if (is<ClassName>(exemplar)) \
typed_array_default_constructor = global_object.snake_name##_constructor();
JS_ENUMERATE_TYPED_ARRAYS
#undef __JS_ENUMERATE
VERIFY(typed_array_default_constructor);
auto* constructor = TRY(species_constructor(global_object, exemplar, *typed_array_default_constructor));
// 3. Let result be ? TypedArrayCreate(constructor, argumentList).
auto* result = TRY(typed_array_create(global_object, *constructor, move(arguments))); auto* result = TRY(typed_array_create(global_object, *constructor, move(arguments)));
// 4. Assert: result has [[TypedArrayName]] and [[ContentType]] internal slots.
// 5. If result.[[ContentType]] ≠ exemplar.[[ContentType]], throw a TypeError exception.
if (result->content_type() != exemplar.content_type()) if (result->content_type() != exemplar.content_type())
return vm.throw_completion<TypeError>(global_object, ErrorType::TypedArrayContentTypeMismatch, result->class_name(), exemplar.class_name()); return vm.throw_completion<TypeError>(global_object, ErrorType::TypedArrayContentTypeMismatch, result->class_name(), exemplar.class_name());
// 6. Return result.
return result; return result;
} }