RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 01:07:35 +00:00
Code Issues Activity Actions

LibJS/Bytecode: Don't choke on MemberExpression with PrivateIdentifier

Browse source
This commit is contained in:
Andreas Kling 2023-06-15 12:38:28 +02:00
parent d063f35afd
commit 8a3e350321
2 changed files with 8 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Userland/Libraries/LibJS/AST.cpp
View file

@ -3289,6 +3289,8 @@ DeprecatedString MemberExpression::to_string_approximation() const
object_string = static_cast<Identifier const&>(*m_object).string();
if (is_computed())
return DeprecatedString::formatted("{}[<computed>]", object_string);
if (is<PrivateIdentifier>(*m_property))
return DeprecatedString::formatted("{}.{}", object_string, verify_cast<PrivateIdentifier>(*m_property).string());
return DeprecatedString::formatted("{}.{}", object_string, verify_cast<Identifier>(*m_property).string());
}

7
Userland/Libraries/LibJS/Bytecode/ASTCodegen.cpp
View file

@ -1357,7 +1357,12 @@ Bytecode::CodeGenerationErrorOr<void> CallExpression::generate_bytecode(Bytecode
TRY(member_expression.property().generate_bytecode(generator));
generator.emit<Bytecode::Op::GetByValue>(this_reg);
} else {
auto identifier_table_ref = generator.intern_identifier(verify_cast<Identifier>(member_expression.property()).string());
auto identifier_table_ref = [&] {
if (is<PrivateIdentifier>(member_expression.property()))
return generator.intern_identifier(verify_cast<PrivateIdentifier>(member_expression.property()).string());
return generator.intern_identifier(verify_cast<Identifier>(member_expression.property()).string());
}();
generator.emit<Bytecode::Op::GetById>(identifier_table_ref);
}
}