mirror of
https://github.com/RGBCube/serenity
synced 2025-07-27 08:37:46 +00:00
LibJS: Implement Temporal.PlainTime.prototype.millisecond
This commit is contained in:
parent
c5f03bc921
commit
8bcccf2577
4 changed files with 30 additions and 0 deletions
|
@ -263,6 +263,7 @@ namespace JS {
|
|||
P(max) \
|
||||
P(message) \
|
||||
P(microseconds) \
|
||||
P(millisecond) \
|
||||
P(milliseconds) \
|
||||
P(min) \
|
||||
P(minute) \
|
||||
|
|
|
@ -30,6 +30,7 @@ void PlainTimePrototype::initialize(GlobalObject& global_object)
|
|||
define_native_accessor(vm.names.hour, hour_getter, {}, Attribute::Configurable);
|
||||
define_native_accessor(vm.names.minute, minute_getter, {}, Attribute::Configurable);
|
||||
define_native_accessor(vm.names.second, second_getter, {}, Attribute::Configurable);
|
||||
define_native_accessor(vm.names.millisecond, millisecond_getter, {}, Attribute::Configurable);
|
||||
|
||||
u8 attr = Attribute::Writable | Attribute::Configurable;
|
||||
define_native_function(vm.names.valueOf, value_of, 0, attr);
|
||||
|
@ -100,6 +101,19 @@ JS_DEFINE_NATIVE_FUNCTION(PlainTimePrototype::second_getter)
|
|||
return Value(temporal_time->iso_second());
|
||||
}
|
||||
|
||||
// 4.3.7 get Temporal.PlainTime.prototype.millisecond, https://tc39.es/proposal-temporal/#sec-get-temporal.plaintime.prototype.millisecond
|
||||
JS_DEFINE_NATIVE_FUNCTION(PlainTimePrototype::millisecond_getter)
|
||||
{
|
||||
// 1. Let temporalTime be the this value.
|
||||
// 2. Perform ? RequireInternalSlot(temporalTime, [[InitializedTemporalTime]]).
|
||||
auto* temporal_time = typed_this(global_object);
|
||||
if (vm.exception())
|
||||
return {};
|
||||
|
||||
// 3. Return 𝔽(temporalTime.[[ISOMillisecond]]).
|
||||
return Value(temporal_time->iso_millisecond());
|
||||
}
|
||||
|
||||
// 4.3.23 Temporal.PlainTime.prototype.valueOf ( ), https://tc39.es/proposal-temporal/#sec-temporal.plaintime.prototype.valueof
|
||||
JS_DEFINE_NATIVE_FUNCTION(PlainTimePrototype::value_of)
|
||||
{
|
||||
|
|
|
@ -23,6 +23,7 @@ private:
|
|||
JS_DECLARE_NATIVE_FUNCTION(hour_getter);
|
||||
JS_DECLARE_NATIVE_FUNCTION(minute_getter);
|
||||
JS_DECLARE_NATIVE_FUNCTION(second_getter);
|
||||
JS_DECLARE_NATIVE_FUNCTION(millisecond_getter);
|
||||
JS_DECLARE_NATIVE_FUNCTION(value_of);
|
||||
};
|
||||
|
||||
|
|
|
@ -0,0 +1,14 @@
|
|||
describe("correct behavior", () => {
|
||||
test("basic functionality", () => {
|
||||
const plainTime = new Temporal.PlainTime(0, 0, 0, 12);
|
||||
expect(plainTime.millisecond).toBe(12);
|
||||
});
|
||||
});
|
||||
|
||||
test("errors", () => {
|
||||
test("this value must be a Temporal.PlainTime object", () => {
|
||||
expect(() => {
|
||||
Reflect.get(Temporal.PlainTime.prototype, "millisecond", "foo");
|
||||
}).toThrowWithMessage(TypeError, "Not a Temporal.PlainTime");
|
||||
});
|
||||
});
|
Loading…
Add table
Add a link
Reference in a new issue