RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 14:17:45 +00:00
Code Issues Activity Actions

LibWasm: Specify which instruction opcode failed validation in error

Browse source
This commit is contained in:
Luke Wilde 2022-10-28 06:00:58 +01:00 • committed by Ali Mohammad Pur
parent 805e6593b9
commit 8fdf4b43cd
1 changed files with 3 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

6
Userland/Libraries/LibWasm/AbstractMachine/Validator.cpp
View file

@ -318,9 +318,9 @@ ErrorOr<void, ValidationError> Validator::validate(Limits const& limits, size_t
}
template<u32 opcode>
ErrorOr<void, ValidationError> Validator::validate_instruction(Instruction const&, Stack&, bool&)
ErrorOr<void, ValidationError> Validator::validate_instruction(Instruction const& instruction, Stack&, bool&)
{
return Errors::invalid("instruction opcode"sv);
return Errors::invalid(String::formatted("instruction opcode (0x{:x}) (missing validation!)", instruction.opcode().value()));
}
#define VALIDATE_INSTRUCTION(name) \
@ -2179,7 +2179,7 @@ ErrorOr<void, ValidationError> Validator::validate(Instruction const& instructio
#undef M
default:
is_constant = false;
return Errors::invalid("instruction opcode"sv);
return Errors::invalid(String::formatted("instruction opcode (0x{:x})", instruction.opcode().value()));
}
}