RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 23:47:45 +00:00
Code Issues Activity Actions

LibWeb: Remove some unchecked .value() calls in StyleValue

Browse source 
Here .to_string() was being called, which gives an ErrorOr<String>,
then .value() was called on that without any checks. Cases like this
should at least be .release_value_but_fixme_should_propagate_errors()
which makes it clear the error is ignored, but here it's easy to
propagate.
This commit is contained in:
MacDue 2023-01-25 19:11:00 +01:00 • committed by Tim Flynn
parent 0c2efa285a
commit 95aacd4f78
1 changed files with 4 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

8
Userland/Libraries/LibWeb/CSS/StyleValue.cpp
View file

@ -1437,13 +1437,13 @@ ErrorOr<String> GridAreaShorthandStyleValue::to_string() const
{
StringBuilder builder;
if (!m_row_start->as_grid_track_placement().grid_track_placement().is_auto())
builder.appendff("{}", m_row_start->as_grid_track_placement().grid_track_placement().to_string().value());
TRY(builder.try_appendff("{}", TRY(m_row_start->as_grid_track_placement().grid_track_placement().to_string())));
if (!m_column_start->as_grid_track_placement().grid_track_placement().is_auto())
builder.appendff(" / {}", m_column_start->as_grid_track_placement().grid_track_placement().to_string().value());
TRY(builder.try_appendff(" / {}", TRY(m_column_start->as_grid_track_placement().grid_track_placement().to_string())));
if (!m_row_end->as_grid_track_placement().grid_track_placement().is_auto())
builder.appendff(" / {}", m_row_end->as_grid_track_placement().grid_track_placement().to_string().value());
TRY(builder.try_appendff(" / {}", TRY(m_row_end->as_grid_track_placement().grid_track_placement().to_string())));
if (!m_column_end->as_grid_track_placement().grid_track_placement().is_auto())
builder.appendff(" / {}", m_column_end->as_grid_track_placement().grid_track_placement().to_string().value());
TRY(builder.try_appendff(" / {}", TRY(m_column_end->as_grid_track_placement().grid_track_placement().to_string())));
return builder.to_string();
}