RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 20:57:44 +00:00
Code Issues Activity Actions

LibJS: Define the Intl.Collator's compare function name to be empty

Browse source
This commit is contained in:
Timothy Flynn 2022-02-21 10:15:51 -05:00 • committed by Linus Groh
parent f3c4146140
commit 96459e4b3a
2 changed files with 5 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

1
Userland/Libraries/LibJS/Runtime/Intl/CollatorCompareFunction.cpp
View file

@ -26,6 +26,7 @@ void CollatorCompareFunction::initialize(GlobalObject& global_object)
{ {
auto& vm = global_object.vm(); auto& vm = global_object.vm();
define_direct_property(vm.names.length, Value(2), Attribute::Configurable); define_direct_property(vm.names.length, Value(2), Attribute::Configurable);
define_direct_property(vm.names.name, js_string(vm, String::empty()), Attribute::Configurable);
} }
// 10.3.3.2 CompareStrings ( collator, x, y ), https://tc39.es/ecma402/#sec-collator-comparestrings // 10.3.3.2 CompareStrings ( collator, x, y ), https://tc39.es/ecma402/#sec-collator-comparestrings

4
Userland/Libraries/LibJS/Tests/builtins/Intl/Collator/Collator.prototype.compare.js
View file

@ -3,6 +3,10 @@ describe("correct behavior", () => {
expect(new Intl.Collator().compare).toHaveLength(2); expect(new Intl.Collator().compare).toHaveLength(2);
}); });
test("name is empty string", () => {
expect(new Intl.Collator().compare.name).toBe("");
});
test("basic functionality", () => { test("basic functionality", () => {
const collator = new Intl.Collator(); const collator = new Intl.Collator();
expect(collator.compare("", "")).toBe(0); expect(collator.compare("", "")).toBe(0);