RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-14 09:34:59 +00:00
Code Issues Activity Actions

less: Fix out of bounds StringView indexing

Browse source 
This fixes indexing the StringView before knowing if the index
is valid. This did not crash until the changes from 13406b8
which added runtime checks for StringView indexing.
This commit is contained in:
MacDue 2022-07-27 12:50:29 +01:00 • committed by Tim Flynn
parent d1671d4f86
commit 9d0dccaa3f
1 changed files with 1 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Userland/Utilities/less.cpp
View file

@ -332,7 +332,7 @@ private:
size_t render_status_line(StringView prompt, size_t off = 0, char end = '\0', bool ignored = false)
{
for (; prompt[off] != end && off < prompt.length(); ++off) {
for (; off < prompt.length() && prompt[off] != end; ++off) {
if (ignored)
continue;