RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 03:37:43 +00:00
Code Issues Activity Actions

LibWeb: Pass scope in ParentNode::query_selector_all

Browse source
This commit is contained in:
Simon Wanner 2023-03-20 23:49:27 +01:00 • committed by Andreas Kling
parent 4e6fb65ea3
commit 9e00ef0849
1 changed files with 10 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

11
Userland/Libraries/LibWeb/DOM/ParentNode.cpp
View file

@ -50,19 +50,28 @@ WebIDL::ExceptionOr<JS::GCPtr<Element>> ParentNode::query_selector(StringView se
return result; return result;
} }
// https://dom.spec.whatwg.org/#dom-parentnode-queryselectorall
WebIDL::ExceptionOr<JS::NonnullGCPtr<NodeList>> ParentNode::query_selector_all(StringView selector_text) WebIDL::ExceptionOr<JS::NonnullGCPtr<NodeList>> ParentNode::query_selector_all(StringView selector_text)
{ {
// The querySelectorAll(selectors) method steps are to return the static result of running scope-match a selectors string selectors against this.
// https://dom.spec.whatwg.org/#scope-match-a-selectors-string
// To scope-match a selectors string selectors against a node, run these steps:
// 1. Let s be the result of parse a selector selectors.
auto maybe_selectors = parse_selector(CSS::Parser::ParsingContext(*this), selector_text); auto maybe_selectors = parse_selector(CSS::Parser::ParsingContext(*this), selector_text);
// 2. If s is failure, then throw a "SyntaxError" DOMException.
if (!maybe_selectors.has_value()) if (!maybe_selectors.has_value())
return WebIDL::SyntaxError::create(realm(), "Failed to parse selector"); return WebIDL::SyntaxError::create(realm(), "Failed to parse selector");
auto selectors = maybe_selectors.value(); auto selectors = maybe_selectors.value();
// 3. Return the result of match a selector against a tree with s and node’s root using scoping root node.
Vector<JS::Handle<Node>> elements; Vector<JS::Handle<Node>> elements;
// FIXME: This should be shadow-including. https://drafts.csswg.org/selectors-4/#match-a-selector-against-a-tree // FIXME: This should be shadow-including. https://drafts.csswg.org/selectors-4/#match-a-selector-against-a-tree
for_each_in_subtree_of_type<Element>([&](auto& element) { for_each_in_subtree_of_type<Element>([&](auto& element) {
for (auto& selector : selectors) { for (auto& selector : selectors) {
if (SelectorEngine::matches(selector, element)) { if (SelectorEngine::matches(selector, element, {}, this)) {
elements.append(&element); elements.append(&element);
} }
} }