RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 06:37:35 +00:00
Code Issues Activity Actions

LibJS: Use fabs() instead of abs() in JS::Value

Browse source 
abs() takes an int, so this would only work correctly for numbers
smaller than INT_MAX.
This commit is contained in:
Andreas Kling 2021-02-15 11:51:08 +01:00
parent 566b916364
commit 9efd80f100
1 changed files with 3 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

6
Userland/Libraries/LibJS/Runtime/Value.cpp
View file

@ -191,7 +191,7 @@ static String double_to_string(double d)
else
builder.append('-');
builder.append(String::format("%d", abs(exponent - 1)));
builder.append(String::number(fabs(exponent - 1)));
return builder.to_string();
}
@ -205,7 +205,7 @@ static String double_to_string(double d)
else
builder.append('-');
builder.append(String::format("%d", abs(exponent - 1)));
builder.append(String::number(fabs(exponent - 1)));
return builder.to_string();
}
@ -576,7 +576,7 @@ double Value::to_integer_or_infinity(GlobalObject& global_object) const
return 0;
if (number.is_infinity())
return number.as_double();
auto integer = floor(abs(number.as_double()));
auto integer = floor(fabs(number.as_double()));
if (number.as_double() < 0)
integer = -integer;
return integer;