RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 03:17:34 +00:00
Code Issues Activity Actions

LibGUI: Add a default virtual destructor to virtual classes

Browse source 
Affected classes are children of TextDocumentUndoCommand:
 - InsertTextCommand
 - RemoveTextCommand
 - ReplaceAllTextCommand
This commit is contained in:
Lucas CHOLLET 2022-06-07 16:07:02 +02:00 • committed by Linus Groh
parent cb4844bf64
commit a85223e13b
1 changed files with 3 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

3
Userland/Libraries/LibGUI/TextDocument.h
View file

@ -215,6 +215,7 @@ protected:
class InsertTextCommand : public TextDocumentUndoCommand { class InsertTextCommand : public TextDocumentUndoCommand {
public: public:
InsertTextCommand(TextDocument&, String const&, TextPosition const&); InsertTextCommand(TextDocument&, String const&, TextPosition const&);
virtual ~InsertTextCommand() = default;
virtual void perform_formatting(TextDocument::Client const&) override; virtual void perform_formatting(TextDocument::Client const&) override;
virtual void undo() override; virtual void undo() override;
virtual void redo() override; virtual void redo() override;
@ -231,6 +232,7 @@ private:
class RemoveTextCommand : public TextDocumentUndoCommand { class RemoveTextCommand : public TextDocumentUndoCommand {
public: public:
RemoveTextCommand(TextDocument&, String const&, TextRange const&); RemoveTextCommand(TextDocument&, String const&, TextRange const&);
virtual ~RemoveTextCommand() = default;
virtual void undo() override; virtual void undo() override;
virtual void redo() override; virtual void redo() override;
TextRange const& range() const { return m_range; } TextRange const& range() const { return m_range; }
@ -246,6 +248,7 @@ class ReplaceAllTextCommand final : public GUI::TextDocumentUndoCommand {
public: public:
ReplaceAllTextCommand(GUI::TextDocument& document, String const& text, GUI::TextRange const& range, String const& action_text); ReplaceAllTextCommand(GUI::TextDocument& document, String const& text, GUI::TextRange const& range, String const& action_text);
virtual ~ReplaceAllTextCommand() = default;
void redo() override; void redo() override;
void undo() override; void undo() override;
bool merge_with(GUI::Command const&) override; bool merge_with(GUI::Command const&) override;