RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 07:17:35 +00:00
Code Issues Activity Actions

LibGL+LibSoftGPU: Clean up some for loops

Browse source
This commit is contained in:
Jelle Raaijmakers 2022-01-20 02:20:42 +01:00 • committed by Andreas Kling
parent 12d7b4e9ac
commit a8655fbf52
2 changed files with 5 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

9
Userland/Libraries/LibGL/SoftwareGLContext.cpp
View file

@ -1980,14 +1980,12 @@ void SoftwareGLContext::get_floating_point(GLenum pname, T* params)
*params = parameter.value.boolean_value ? GL_TRUE : GL_FALSE; *params = parameter.value.boolean_value ? GL_TRUE : GL_FALSE;
break; break;
case GL_DOUBLE: case GL_DOUBLE:
for (size_t i = 0; i < parameter.count; ++i) { for (size_t i = 0; i < parameter.count; ++i)
params[i] = parameter.value.double_list[i]; params[i] = parameter.value.double_list[i];
}
break; break;
case GL_INT: case GL_INT:
for (size_t i = 0; i < parameter.count; ++i) { for (size_t i = 0; i < parameter.count; ++i)
params[i] = parameter.value.integer_list[i]; params[i] = parameter.value.integer_list[i];
}
break; break;
default: default:
VERIFY_NOT_REACHED(); VERIFY_NOT_REACHED();
@ -2015,9 +2013,8 @@ void SoftwareGLContext::gl_get_integerv(GLenum pname, GLint* data)
break; break;
} }
case GL_INT: case GL_INT:
for (size_t i = 0; i < parameter.count; ++i) { for (size_t i = 0; i < parameter.count; ++i)
data[i] = parameter.value.integer_list[i]; data[i] = parameter.value.integer_list[i];
}
break; break;
default: default:
VERIFY_NOT_REACHED(); VERIFY_NOT_REACHED();

4
Userland/Libraries/LibSoftGPU/Device.cpp
View file

@ -733,8 +733,8 @@ void Device::draw_primitives(PrimitiveType primitive_type, FloatMatrix4x4 const&
Triangle triangle; Triangle triangle;
triangle.vertices[0] = vertices.at(0); // Root vertex is always the vertex defined first triangle.vertices[0] = vertices.at(0); // Root vertex is always the vertex defined first
for (size_t i = 1; i < vertices.size() - 1; i++) // This is technically `n-2` triangles. We start at index 1 // This is technically `n-2` triangles. We start at index 1
{ for (size_t i = 1; i < vertices.size() - 1; i++) {
triangle.vertices[1] = vertices.at(i); triangle.vertices[1] = vertices.at(i);
triangle.vertices[2] = vertices.at(i + 1); triangle.vertices[2] = vertices.at(i + 1);
m_triangle_list.append(triangle); m_triangle_list.append(triangle);