RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 03:27:45 +00:00
Code Issues Activity Actions

LibCore: Change DateTime format strings to be StringViews

Browse source 
There's no need to allocate a String for these. Note the "string"
parameter of DateTime::parse is left as a String for now; the parser is
currently using strtol which needs a NUL-terminated string. This method
can likely be rewritten with GenericLexer.
This commit is contained in:
Timothy Flynn 2022-01-28 14:26:43 -05:00 • committed by Linus Groh
parent 9c80430eea
commit b387ac56b6
2 changed files with 5 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

4
Userland/Libraries/LibCore/DateTime.cpp
View file

@ -83,7 +83,7 @@ void DateTime::set_time(int year, int month, int day, int hour, int minute, int
m_second = tm.tm_sec; m_second = tm.tm_sec;
} }
String DateTime::to_string(const String& format) const String DateTime::to_string(StringView format) const
{ {
const char wday_short_names[7][4] = { const char wday_short_names[7][4] = {
"Sun", "Mon", "Tue", "Wed", "Thu", "Fri", "Sat" "Sun", "Mon", "Tue", "Wed", "Thu", "Fri", "Sat"
@ -261,7 +261,7 @@ String DateTime::to_string(const String& format) const
return builder.build(); return builder.build();
} }
Optional<DateTime> DateTime::parse(const String& format, const String& string) Optional<DateTime> DateTime::parse(StringView format, const String& string)
{ {
unsigned format_pos = 0; unsigned format_pos = 0;
unsigned string_pos = 0; unsigned string_pos = 0;

5
Userland/Libraries/LibCore/DateTime.h
View file

@ -7,6 +7,7 @@
#pragma once #pragma once
#include <AK/String.h> #include <AK/String.h>
#include <AK/StringView.h>
#include <LibIPC/Forward.h> #include <LibIPC/Forward.h>
#include <time.h> #include <time.h>
@ -30,12 +31,12 @@ public:
bool is_leap_year() const; bool is_leap_year() const;
void set_time(int year, int month = 1, int day = 1, int hour = 0, int minute = 0, int second = 0); void set_time(int year, int month = 1, int day = 1, int hour = 0, int minute = 0, int second = 0);
String to_string(const String& format = "%Y-%m-%d %H:%M:%S") const; String to_string(StringView format = "%Y-%m-%d %H:%M:%S"sv) const;
static DateTime create(int year, int month = 1, int day = 1, int hour = 0, int minute = 0, int second = 0); static DateTime create(int year, int month = 1, int day = 1, int hour = 0, int minute = 0, int second = 0);
static DateTime now(); static DateTime now();
static DateTime from_timestamp(time_t); static DateTime from_timestamp(time_t);
static Optional<DateTime> parse(const String& format, const String& string); static Optional<DateTime> parse(StringView format, const String& string);
bool operator<(const DateTime& other) const { return m_timestamp < other.m_timestamp; } bool operator<(const DateTime& other) const { return m_timestamp < other.m_timestamp; }