RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 18:07:34 +00:00
Code Issues Activity Actions

Libraries: Fix visibility of Object-derivative constructors

Browse source 
Derivatives of Core::Object should be constructed through
ClassName::construct(), to avoid handling ref-counted objects with
refcount zero. Fixing the visibility means that misuses like this are
more difficult.
This commit is contained in:
Ben Wiederhake 2021-10-31 23:38:04 +01:00 • committed by Andreas Kling
parent 3796d417e0
commit b3e9a4e603
19 changed files with 62 additions and 50 deletions
Download patch file Download diff file Expand all files Collapse all files

3
Userland/Libraries/LibGUI/AbstractScrollableWidget.h
View file

@ -81,7 +81,7 @@ private:
class AbstractScrollableWidgetScrollbar final : public Scrollbar {
C_OBJECT(AbstractScrollableWidgetScrollbar);
protected:
private:
explicit AbstractScrollableWidgetScrollbar(AbstractScrollableWidget& owner, Gfx::Orientation orientation)
: Scrollbar(orientation)
, m_owner(owner)
@ -93,7 +93,6 @@ private:
m_owner.handle_wheel_event(event, *this);
}
private:
AbstractScrollableWidget& m_owner;
};
friend class ScrollableWidgetScrollbar;