RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-31 16:38:10 +00:00
Code Issues Activity Actions

Libraries: Fix visibility of Object-derivative constructors

Browse source 
Derivatives of Core::Object should be constructed through
ClassName::construct(), to avoid handling ref-counted objects with
refcount zero. Fixing the visibility means that misuses like this are
more difficult.
This commit is contained in:
Ben Wiederhake 2021-10-31 23:38:04 +01:00 • committed by Andreas Kling
parent 3796d417e0
commit b3e9a4e603
19 changed files with 62 additions and 50 deletions
Download patch file Download diff file Expand all files Collapse all files

3
Userland/Libraries/LibWebSocket/Impl/TCPWebSocketConnectionImpl.h
View file

@ -22,7 +22,6 @@ class TCPWebSocketConnectionImpl final : public AbstractWebSocketImpl {
public:
virtual ~TCPWebSocketConnectionImpl() override;
explicit TCPWebSocketConnectionImpl(Core::Object* parent = nullptr);
virtual void connect(ConnectionInfo const& connection) override;
@ -39,6 +38,8 @@ public:
virtual void discard_connection() override;
private:
explicit TCPWebSocketConnectionImpl(Core::Object* parent = nullptr);
RefPtr<Core::Notifier> m_notifier;
RefPtr<Core::TCPSocket> m_socket;
};