RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-22 18:55:07 +00:00
Code Issues Activity Actions

LibJS: Add bytecode generation for simple ObjectExpressions

Browse source 
Bytecode is now generated for object literals which only contain simple
key-value pairs (i.e. no spread, getters or setters)
This commit is contained in:
Gal Horowitz 2021-06-11 19:40:48 +03:00 • committed by Andreas Kling
parent e0fb36aad7
commit b47d117bd2
1 changed files with 26 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

26
Userland/Libraries/LibJS/Bytecode/ASTCodegen.cpp
View file

@ -560,9 +560,33 @@ void ForStatement::generate_bytecode(Bytecode::Generator& generator) const
void ObjectExpression::generate_bytecode(Bytecode::Generator& generator) const void ObjectExpression::generate_bytecode(Bytecode::Generator& generator) const
{ {
generator.emit<Bytecode::Op::NewObject>(); generator.emit<Bytecode::Op::NewObject>();
if (m_properties.is_empty())
return;
if (!m_properties.is_empty()) auto object_reg = generator.allocate_register();
generator.emit<Bytecode::Op::Store>(object_reg);
for (auto& property : m_properties) {
if (property.type() != ObjectProperty::Type::KeyValue)
TODO(); TODO();
if (is<StringLiteral>(property.key())) {
auto& string_literal = static_cast<StringLiteral const&>(property.key());
Bytecode::StringTableIndex key_name = generator.intern_string(string_literal.value());
property.value().generate_bytecode(generator);
generator.emit<Bytecode::Op::PutById>(object_reg, key_name);
} else {
property.key().generate_bytecode(generator);
auto property_reg = generator.allocate_register();
generator.emit<Bytecode::Op::Store>(property_reg);
property.value().generate_bytecode(generator);
generator.emit<Bytecode::Op::PutByValue>(object_reg, property_reg);
}
}
generator.emit<Bytecode::Op::Load>(object_reg);
} }
void ArrayExpression::generate_bytecode(Bytecode::Generator& generator) const void ArrayExpression::generate_bytecode(Bytecode::Generator& generator) const