RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-27 16:17:36 +00:00
Code Issues Activity Actions

LibJS: Disable Temporal custom time zone test

Browse source 
This test has been flaky for quite some time. Disable it for now, and
revisit once we've caught up with the Temporal spec.
This commit is contained in:
Timothy Flynn 2023-08-27 14:52:29 -04:00 • committed by Tim Flynn
parent edd49c1531
commit b7676cc436
1 changed files with 8 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

9
Userland/Libraries/LibJS/Tests/builtins/Temporal/Now/Now.plainDateTimeISO.js
View file

@ -28,7 +28,10 @@ describe("correct behavior", () => {
// and negative timezones and skip one if we jump the year. To ensure at least one is // and negative timezones and skip one if we jump the year. To ensure at least one is
// tested we have the timeZoneTested which is only set to true if one of the tests passed. // tested we have the timeZoneTested which is only set to true if one of the tests passed.
test("custom time zone positive", () => { // FIXME: The custom time zone tests are disabled due to being flaky. See:
// https://github.com/SerenityOS/serenity/issues/20806
test.skip("custom time zone (positive)", () => {
const timeZone = { const timeZone = {
getOffsetNanosecondsFor() { getOffsetNanosecondsFor() {
return 86399999999999; return 86399999999999;
@ -48,7 +51,7 @@ describe("correct behavior", () => {
timeZoneTested = true; timeZoneTested = true;
}); });
test("custom time zone negative", () => { test.skip("custom time zone (negative)", () => {
const timeZone = { const timeZone = {
getOffsetNanosecondsFor() { getOffsetNanosecondsFor() {
return -86399999999999; return -86399999999999;
@ -68,7 +71,9 @@ describe("correct behavior", () => {
timeZoneTested = true; timeZoneTested = true;
}); });
test.skip("custom time zone test was executed", () => {
expect(timeZoneTested).toBeTrue(); expect(timeZoneTested).toBeTrue();
});
test("cannot have a time zone with more than a day", () => { test("cannot have a time zone with more than a day", () => {
[86400000000000, -86400000000000, 86400000000001, 86400000000002].forEach(offset => { [86400000000000, -86400000000000, 86400000000001, 86400000000002].forEach(offset => {