RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 12:47:35 +00:00
Code Issues Activity Actions

TextEditor: Let's have line numbers starting at 1.

Browse source 
Thanks to Dan for pointing this out on IRC:

<danboid> I see TextEditor still numbers its lines from 0. You're too much of a programmer sometimes kling! :)
<  kling> that might be the most extreme form of "programmer design" I've seen in serenity
This commit is contained in:
Andreas Kling 2019-07-27 21:20:38 +02:00
parent 6a0319697c
commit b98c77229d
2 changed files with 2 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Applications/TextEditor/TextEditorWidget.cpp
View file

@ -25,7 +25,7 @@ TextEditorWidget::TextEditorWidget()
m_editor->on_cursor_change = [statusbar, this] { m_editor->on_cursor_change = [statusbar, this] {
StringBuilder builder; StringBuilder builder;
builder.appendf("Line: %d, Column: %d", m_editor->cursor().line(), m_editor->cursor().column()); builder.appendf("Line: %d, Column: %d", m_editor->cursor().line() + 1, m_editor->cursor().column());
statusbar->set_text(builder.to_string()); statusbar->set_text(builder.to_string());
}; };

2
Libraries/LibGUI/GTextEditor.cpp
View file

@ -292,7 +292,7 @@ void GTextEditor::paint_event(GPaintEvent& event)
auto ruler_line_rect = ruler_content_rect(i); auto ruler_line_rect = ruler_content_rect(i);
painter.draw_text( painter.draw_text(
ruler_line_rect.shrunken(2, 0), ruler_line_rect.shrunken(2, 0),
String::number(i), String::number(i + 1),
is_current_line ? Font::default_bold_font() : font(), is_current_line ? Font::default_bold_font() : font(),
TextAlignment::CenterRight, TextAlignment::CenterRight,
is_current_line ? Color::DarkGray : Color::MidGray); is_current_line ? Color::DarkGray : Color::MidGray);