RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-31 08:38:12 +00:00
Code Issues Activity Actions

LibWeb: Don't have Handle<Realm> in WindowEnvironmentSettingsObject

Browse source 
This was preventing window realms from ever being garbage collected.
This commit is contained in:
Andreas Kling 2022-09-01 12:14:28 +02:00
parent 5f4d4ffe39
commit c569c88e63
2 changed files with 2 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Userland/Libraries/LibWeb/HTML/Scripting/WindowEnvironmentSettingsObject.cpp
View file

@ -12,7 +12,7 @@ namespace Web::HTML {
WindowEnvironmentSettingsObject::WindowEnvironmentSettingsObject(Window& window, NonnullOwnPtr<JS::ExecutionContext> execution_context) WindowEnvironmentSettingsObject::WindowEnvironmentSettingsObject(Window& window, NonnullOwnPtr<JS::ExecutionContext> execution_context)
: EnvironmentSettingsObject(move(execution_context)) : EnvironmentSettingsObject(move(execution_context))
, m_window(JS::make_handle(window)) , m_window(window)
{ {
} }

2
Userland/Libraries/LibWeb/HTML/Scripting/WindowEnvironmentSettingsObject.h
View file

@ -26,7 +26,7 @@ public:
private: private:
WindowEnvironmentSettingsObject(Window&, NonnullOwnPtr<JS::ExecutionContext>); WindowEnvironmentSettingsObject(Window&, NonnullOwnPtr<JS::ExecutionContext>);
JS::Handle<Window> m_window; WeakPtr<Window> m_window;
}; };
} }