RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-27 00:47:45 +00:00
Code Issues Activity Actions

LibWeb: Report when CanvasFillOrStrokeStyle parsing fails

Browse source
This commit is contained in:
timmot 2023-11-18 21:08:25 +11:00 • committed by Andreas Kling
parent 2ecc1d64d8
commit c713445253
1 changed files with 7 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

8
Userland/Libraries/LibWeb/HTML/Canvas/CanvasFillStrokeStyles.h
View file

@ -27,7 +27,13 @@ public:
{ {
return style.visit( return style.visit(
[&](String const& string) -> CanvasState::FillOrStrokeStyle { [&](String const& string) -> CanvasState::FillOrStrokeStyle {
return Gfx::Color::from_string(string).value_or(Color::Black); // FIXME: This should parse color strings the same as CSS
auto color = Gfx::Color::from_string(string);
if (!color.has_value())
dbgln_if(CANVAS_RENDERING_CONTEXT_2D_DEBUG, "CanvasFillStrokeStyles: Unsupported canvas fill or stroke style \"{}\". Defaulting to Color::Black.", string);
return color.value_or(Color::Black);
}, },
[&](auto fill_or_stroke_style) -> CanvasState::FillOrStrokeStyle { [&](auto fill_or_stroke_style) -> CanvasState::FillOrStrokeStyle {
return fill_or_stroke_style; return fill_or_stroke_style;