RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 05:17:35 +00:00
Code Issues Activity Actions

Libraries: Use default constructors/destructors in LibCoredump

Browse source 
https://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines#cother-other-default-operation-rules

"The compiler is more likely to get the default semantics right and
you cannot implement these functions better than the compiler."
This commit is contained in:
Lenny Maiorani 2022-02-26 10:30:24 -07:00 • committed by Brian Gianforcaro
parent ea58b8d927
commit cb87d13dd5
4 changed files with 5 additions and 10 deletions
Download patch file Download diff file Expand all files Collapse all files

5
Userland/Libraries/LibCoredump/Backtrace.cpp
View file

@ -1,5 +1,6 @@
/* /*
* Copyright (c) 2020, Linus Groh <linusg@serenityos.org> * Copyright (c) 2020, Linus Groh <linusg@serenityos.org>
* Copyright (c) 2022, the SerenityOS developers.
* *
* SPDX-License-Identifier: BSD-2-Clause * SPDX-License-Identifier: BSD-2-Clause
*/ */
@ -91,10 +92,6 @@ Backtrace::Backtrace(const Reader& coredump, const ELF::Core::ThreadInfo& thread
} }
} }
Backtrace::~Backtrace()
{
}
void Backtrace::add_entry(const Reader& coredump, FlatPtr ip) void Backtrace::add_entry(const Reader& coredump, FlatPtr ip)
{ {
auto ip_region = coredump.region_containing(ip); auto ip_region = coredump.region_containing(ip);

3
Userland/Libraries/LibCoredump/Backtrace.h
View file

@ -1,5 +1,6 @@
/* /*
* Copyright (c) 2020, Linus Groh <linusg@serenityos.org> * Copyright (c) 2020, Linus Groh <linusg@serenityos.org>
* Copyright (c) 2022, the SerenityOS developers.
* *
* SPDX-License-Identifier: BSD-2-Clause * SPDX-License-Identifier: BSD-2-Clause
*/ */
@ -38,7 +39,7 @@ public:
}; };
Backtrace(const Reader&, const ELF::Core::ThreadInfo&, Function<void(size_t, size_t)> on_progress = {}); Backtrace(const Reader&, const ELF::Core::ThreadInfo&, Function<void(size_t, size_t)> on_progress = {});
~Backtrace(); ~Backtrace() = default;
ELF::Core::ThreadInfo const& thread_info() const { return m_thread_info; } ELF::Core::ThreadInfo const& thread_info() const { return m_thread_info; }
Vector<Entry> const& entries() const { return m_entries; } Vector<Entry> const& entries() const { return m_entries; }

5
Userland/Libraries/LibCoredump/Reader.cpp
View file

@ -1,5 +1,6 @@
/* /*
* Copyright (c) 2020, Itamar S. <itamar8910@gmail.com> * Copyright (c) 2020, Itamar S. <itamar8910@gmail.com>
* Copyright (c) 2022, the SerenityOS developers.
* *
* SPDX-License-Identifier: BSD-2-Clause * SPDX-License-Identifier: BSD-2-Clause
*/ */
@ -76,10 +77,6 @@ Optional<ByteBuffer> Reader::decompress_coredump(ReadonlyBytes raw_coredump)
return bytebuffer.release_value(); return bytebuffer.release_value();
} }
Reader::~Reader()
{
}
Reader::NotesEntryIterator::NotesEntryIterator(const u8* notes_data) Reader::NotesEntryIterator::NotesEntryIterator(const u8* notes_data)
: m_current(bit_cast<const ELF::Core::NotesEntry*>(notes_data)) : m_current(bit_cast<const ELF::Core::NotesEntry*>(notes_data))
, start(notes_data) , start(notes_data)

2
Userland/Libraries/LibCoredump/Reader.h
View file

@ -40,7 +40,7 @@ class Reader {
public: public:
static OwnPtr<Reader> create(StringView); static OwnPtr<Reader> create(StringView);
~Reader(); ~Reader() = default;
template<typename Func> template<typename Func>
void for_each_memory_region_info(Func func) const; void for_each_memory_region_info(Func func) const;