RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-10-31 07:02:44 +00:00
Code Issues Activity Actions

LibWeb: Create XMLDocuments in DOMImplementation.createDocument

Browse source
This commit is contained in:
Shannon Booth 2024-01-04 12:36:11 +13:00 • committed by Andreas Kling
parent 36c145b197
commit cd156bad6b
3 changed files with 11 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

1
Tests/LibWeb/Text/expected/DOM/DOMImplementation-create-xml-document.txt Normal file
View file

@ -0,0 +1 @@
XMLDocument

7
Tests/LibWeb/Text/input/DOM/DOMImplementation-create-xml-document.html Normal file
View file

@ -0,0 +1,7 @@
<script src="../include.js"></script>
<script>
test(() => {
const xmlDoc = document.implementation.createDocument(null, "books");
println(xmlDoc.constructor.name);
});
</script>

6
Userland/Libraries/LibWeb/DOM/DOMImplementation.cpp
View file

@ -8,10 +8,10 @@
#include <LibWeb/Bindings/Intrinsics.h>
#include <LibWeb/Bindings/MainThreadVM.h>
#include <LibWeb/DOM/DOMImplementation.h>
#include <LibWeb/DOM/Document.h>
#include <LibWeb/DOM/DocumentType.h>
#include <LibWeb/DOM/ElementFactory.h>
#include <LibWeb/DOM/Text.h>
#include <LibWeb/DOM/XMLDocument.h>
#include <LibWeb/HTML/Origin.h>
#include <LibWeb/Namespace.h>
@ -48,8 +48,8 @@ void DOMImplementation::visit_edges(Cell::Visitor& visitor)
// https://dom.spec.whatwg.org/#dom-domimplementation-createdocument
WebIDL::ExceptionOr<JS::NonnullGCPtr<Document>> DOMImplementation::create_document(Optional<String> const& namespace_, String const& qualified_name, JS::GCPtr<DocumentType> doctype) const
{
// FIXME: 1. Let document be a new XMLDocument
auto xml_document = Document::create(realm());
// 1. Let document be a new XMLDocument
auto xml_document = XMLDocument::create(realm());
xml_document->set_ready_for_post_load_tasks(true);