RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-27 05:47:35 +00:00
Code Issues Activity Actions

LibELF: Use member initialization for AuxiliaryVector::optional_string

Browse source 
When the member is initialized in the constructor body, but also has a
default constructor, you pay for default construction to just throw it
away. In this case a StringView is light weight to initialize, but we
might as well fix all cases we find.

Found by PVS-Studio: https://pvs-studio.com/en/docs/warnings/v818/
This commit is contained in:
Brian Gianforcaro 2021-10-09 23:53:47 -07:00 • committed by Andreas Kling
parent 7b2506c054
commit d347432a9e
1 changed files with 1 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Userland/Libraries/LibELF/AuxiliaryVector.h
View file

@ -90,10 +90,10 @@ struct AuxiliaryValue {
auxv.a_un.a_ptr = (void*)ptr; auxv.a_un.a_ptr = (void*)ptr;
} }
AuxiliaryValue(Type type, StringView string) AuxiliaryValue(Type type, StringView string)
: optional_string(string)
{ {
auxv.a_type = type; auxv.a_type = type;
auxv.a_un.a_ptr = nullptr; auxv.a_un.a_ptr = nullptr;
optional_string = string;
} }
auxv_t auxv {}; auxv_t auxv {};