1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-23 10:37:41 +00:00

LibJS+LibWeb+Spreadsheet: Upcall visit_edges() via Base typedef

Let's use Base::visit_edges() when calling the base class, to prevent
accidentally skipping over anyone in the inheritance chain.
This commit is contained in:
Andreas Kling 2021-09-11 14:05:12 +02:00
parent 19ee5e01ad
commit d42d655853
16 changed files with 16 additions and 16 deletions

View file

@ -150,7 +150,7 @@ void SheetGlobalObject::initialize_global_object()
void SheetGlobalObject::visit_edges(Visitor& visitor)
{
GlobalObject::visit_edges(visitor);
Base::visit_edges(visitor);
for (auto& it : m_sheet.cells()) {
if (it.value->exception())
visitor.visit(it.value->exception());

View file

@ -44,7 +44,7 @@ ArrayBuffer::~ArrayBuffer()
void ArrayBuffer::visit_edges(Cell::Visitor& visitor)
{
Object::visit_edges(visitor);
Base::visit_edges(visitor);
visitor.visit(m_detach_key);
}

View file

@ -26,7 +26,7 @@ BigIntObject::~BigIntObject()
void BigIntObject::visit_edges(Cell::Visitor& visitor)
{
Object::visit_edges(visitor);
Base::visit_edges(visitor);
visitor.visit(&m_bigint);
}

View file

@ -27,7 +27,7 @@ DataView::~DataView()
void DataView::visit_edges(Visitor& visitor)
{
Object::visit_edges(visitor);
Base::visit_edges(visitor);
visitor.visit(m_viewed_array_buffer);
}

View file

@ -75,7 +75,7 @@ void FinalizationRegistry::cleanup(FunctionObject* callback)
void FinalizationRegistry::visit_edges(Cell::Visitor& visitor)
{
Object::visit_edges(visitor);
Base::visit_edges(visitor);
visitor.visit(m_cleanup_callback);
for (auto& record : m_records) {
visitor.visit(record.held_value);

View file

@ -85,7 +85,7 @@ void FunctionObject::InstanceField::define_field(VM& vm, Object& receiver) const
void FunctionObject::visit_edges(Visitor& visitor)
{
Object::visit_edges(visitor);
Base::visit_edges(visitor);
visitor.visit(m_home_object);
visitor.visit(m_bound_this);

View file

@ -43,7 +43,7 @@ GeneratorObject::~GeneratorObject()
void GeneratorObject::visit_edges(Cell::Visitor& visitor)
{
Object::visit_edges(visitor);
Base::visit_edges(visitor);
visitor.visit(m_environment);
visitor.visit(m_generating_function);
if (m_previous_value.is_object())

View file

@ -24,7 +24,7 @@ Map::~Map()
void Map::visit_edges(Cell::Visitor& visitor)
{
Object::visit_edges(visitor);
Base::visit_edges(visitor);
for (auto& value : m_entries) {
visitor.visit(value.key);
visitor.visit(value.value);

View file

@ -1023,7 +1023,7 @@ Value ProxyObject::construct(FunctionObject& new_target)
void ProxyObject::visit_edges(Cell::Visitor& visitor)
{
FunctionObject::visit_edges(visitor);
Base::visit_edges(visitor);
visitor.visit(&m_target);
visitor.visit(&m_handler);
}

View file

@ -26,7 +26,7 @@ RegExpStringIterator::RegExpStringIterator(Object& prototype, Object& regexp_obj
void RegExpStringIterator::visit_edges(Cell::Visitor& visitor)
{
Object::visit_edges(visitor);
Base::visit_edges(visitor);
visitor.visit(&m_regexp_object);
}

View file

@ -24,7 +24,7 @@ Set::~Set()
void Set::visit_edges(Cell::Visitor& visitor)
{
Object::visit_edges(visitor);
Base::visit_edges(visitor);
for (auto& value : m_values)
visitor.visit(value);
}

View file

@ -39,7 +39,7 @@ void StringObject::initialize(GlobalObject& global_object)
void StringObject::visit_edges(Cell::Visitor& visitor)
{
Object::visit_edges(visitor);
Base::visit_edges(visitor);
visitor.visit(&m_string);
}

View file

@ -27,7 +27,7 @@ SymbolObject::~SymbolObject()
void SymbolObject::visit_edges(Cell::Visitor& visitor)
{
Object::visit_edges(visitor);
Base::visit_edges(visitor);
visitor.visit(&m_symbol);
}

View file

@ -263,7 +263,7 @@ TypedArrayBase* typed_array_create(GlobalObject& global_object, FunctionObject&
void TypedArrayBase::visit_edges(Visitor& visitor)
{
Object::visit_edges(visitor);
Base::visit_edges(visitor);
visitor.visit(m_viewed_array_buffer);
}

View file

@ -41,7 +41,7 @@ void WeakRef::remove_swept_cells(Badge<Heap>, Span<Cell*> cells)
void WeakRef::visit_edges(Visitor& visitor)
{
Object::visit_edges(visitor);
Base::visit_edges(visitor);
if (vm().execution_generation() == m_last_execution_generation)
visitor.visit(m_value);

View file

@ -59,7 +59,7 @@ void WebAssemblyInstanceObject::initialize(JS::GlobalObject& global_object)
void WebAssemblyInstanceObject::visit_edges(Visitor& visitor)
{
Object::visit_edges(visitor);
Base::visit_edges(visitor);
visitor.visit(m_exports_object);
}