RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-24 20:57:35 +00:00
Code Issues Activity Actions

LibSQL: Use compiler generated default functions

Browse source 
Problem:
- Clang ToT generates warnings due to user-declared functions causing
  the implicitly generated assignment operator to not be generated.

Solution:
- Declare the default constructor `= default`.
- Remove the default copy constructor declaration.
This commit is contained in:
Lenny Maiorani 2021-08-03 12:36:58 -06:00 • committed by Andreas Kling
parent 91c9d9ee88
commit da10ad3f0d
2 changed files with 1 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

5
Userland/Libraries/LibSQL/Key.cpp
View file

@ -9,11 +9,6 @@
namespace SQL { namespace SQL {
Key::Key()
: Tuple()
{
}
Key::Key(TupleDescriptor const& descriptor) Key::Key(TupleDescriptor const& descriptor)
: Tuple(descriptor) : Tuple(descriptor)
{ {

3
Userland/Libraries/LibSQL/Key.h
View file

@ -14,12 +14,11 @@ namespace SQL {
class Key : public Tuple { class Key : public Tuple {
public: public:
Key(); Key() = default;
explicit Key(TupleDescriptor const&); explicit Key(TupleDescriptor const&);
explicit Key(RefPtr<IndexDef>); explicit Key(RefPtr<IndexDef>);
Key(TupleDescriptor const&, ByteBuffer&, size_t& offset); Key(TupleDescriptor const&, ByteBuffer&, size_t& offset);
Key(RefPtr<IndexDef>, ByteBuffer&, size_t& offset); Key(RefPtr<IndexDef>, ByteBuffer&, size_t& offset);
Key(Key const&) = default;
RefPtr<IndexDef> index() const { return m_index; } RefPtr<IndexDef> index() const { return m_index; }
[[nodiscard]] virtual size_t data_length() const override { return Tuple::data_length() + sizeof(u32); } [[nodiscard]] virtual size_t data_length() const override { return Tuple::data_length() + sizeof(u32); }