RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 19:07:35 +00:00
Code Issues Activity Actions

LibJS: Add missing exception check to ArrayPrototype's for_each_item()

Browse source 
Object::get_by_index() cannot throw for positive indices *right now*,
but once we implement descriptors for array index properties, it can.
This commit is contained in:
Linus Groh 2020-05-22 23:17:10 +01:00 • committed by Andreas Kling
parent 843e000f18
commit daf74838dd
1 changed files with 2 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Libraries/LibJS/Runtime/ArrayPrototype.cpp
View file

@ -111,6 +111,8 @@ static void for_each_item(Interpreter& interpreter, const String& name, AK::Func
for (size_t i = 0; i < initial_length; ++i) { for (size_t i = 0; i < initial_length; ++i) {
auto value = this_object->get_by_index(i); auto value = this_object->get_by_index(i);
if (interpreter.exception())
return;
if (value.is_empty()) { if (value.is_empty()) {
if (skip_empty) if (skip_empty)
continue; continue;