mirror of
https://github.com/RGBCube/serenity
synced 2025-07-25 17:17:44 +00:00
LibJS: Implement Temporal.Duration.prototype.minutes
This commit is contained in:
parent
067c2346ed
commit
dbdbfbeebc
4 changed files with 30 additions and 0 deletions
|
@ -238,6 +238,7 @@ namespace JS {
|
|||
P(max) \
|
||||
P(message) \
|
||||
P(min) \
|
||||
P(minutes) \
|
||||
P(months) \
|
||||
P(multiline) \
|
||||
P(name) \
|
||||
|
|
|
@ -30,6 +30,7 @@ void DurationPrototype::initialize(GlobalObject& global_object)
|
|||
define_native_accessor(vm.names.weeks, weeks_getter, {}, Attribute::Configurable);
|
||||
define_native_accessor(vm.names.days, days_getter, {}, Attribute::Configurable);
|
||||
define_native_accessor(vm.names.hours, hours_getter, {}, Attribute::Configurable);
|
||||
define_native_accessor(vm.names.minutes, minutes_getter, {}, Attribute::Configurable);
|
||||
}
|
||||
|
||||
static Duration* typed_this(GlobalObject& global_object)
|
||||
|
@ -110,4 +111,17 @@ JS_DEFINE_NATIVE_FUNCTION(DurationPrototype::hours_getter)
|
|||
return Value(duration->hours());
|
||||
}
|
||||
|
||||
// 7.3.8 get Temporal.Duration.prototype.minutes, https://tc39.es/proposal-temporal/#sec-get-temporal.duration.prototype.minutes
|
||||
JS_DEFINE_NATIVE_FUNCTION(DurationPrototype::minutes_getter)
|
||||
{
|
||||
// 1. Let duration be the this value.
|
||||
// 2. Perform ? RequireInternalSlot(duration, [[InitializedTemporalDuration]]).
|
||||
auto* duration = typed_this(global_object);
|
||||
if (vm.exception())
|
||||
return {};
|
||||
|
||||
// 3. Return duration.[[Minutes]].
|
||||
return Value(duration->minutes());
|
||||
}
|
||||
|
||||
}
|
||||
|
|
|
@ -24,6 +24,7 @@ private:
|
|||
JS_DECLARE_NATIVE_FUNCTION(weeks_getter);
|
||||
JS_DECLARE_NATIVE_FUNCTION(days_getter);
|
||||
JS_DECLARE_NATIVE_FUNCTION(hours_getter);
|
||||
JS_DECLARE_NATIVE_FUNCTION(minutes_getter);
|
||||
};
|
||||
|
||||
}
|
||||
|
|
|
@ -0,0 +1,14 @@
|
|||
describe("correct behavior", () => {
|
||||
test("basic functionality", () => {
|
||||
const duration = new Temporal.Duration(0, 0, 0, 0, 0, 123);
|
||||
expect(duration.minutes).toBe(123);
|
||||
});
|
||||
});
|
||||
|
||||
test("errors", () => {
|
||||
test("this value must be a Temporal.Duration object", () => {
|
||||
expect(() => {
|
||||
Reflect.get(Temporal.Duration.prototype, "minutes", "foo");
|
||||
}).toThrowWithMessage(TypeError, "Not a Temporal.Duration");
|
||||
});
|
||||
});
|
Loading…
Add table
Add a link
Reference in a new issue