RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-14 06:04:57 +00:00
Code Issues Activity Actions

LibVT: Fix integer overflow when parsing long OSC sequences

Browse source 
We were storing indices into OSC escape sequences as `u8`s, which
overflow at a length of just 256 characters. This caused a crash when
parsing OSC 8 hyperlinks pointing to long filenames.
This commit is contained in:
Daniel Bertalan 2023-03-17 17:41:53 +01:00 • committed by Linus Groh
parent 5d7a85bc37
commit e3195b060d
1 changed files with 1 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Userland/Libraries/LibVT/EscapeSequenceParser.h
View file

@ -69,7 +69,7 @@ private:
Vector<unsigned, 4> m_param_vector;
unsigned m_param { 0 };
Vector<u8> m_osc_parameter_indexes;
Vector<size_t> m_osc_parameter_indexes;
Vector<u8, 16> m_osc_raw;
bool m_ignoring { false };