RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 05:37:35 +00:00
Code Issues Activity Actions

LibSQL: Return a not-yet-implemented error for unimplemented expressions

Browse source 
Easier to debug than returning a NULL value.
This commit is contained in:
Timothy Flynn 2022-02-10 17:58:55 -05:00 • committed by Linus Groh
parent 5c90aa357b
commit e649ff5d31
2 changed files with 4 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

5
Userland/Libraries/LibSQL/AST/AST.h
View file

@ -305,7 +305,10 @@ struct ExecutionContext {
class Expression : public ASTNode { class Expression : public ASTNode {
public: public:
virtual ResultOr<Value> evaluate(ExecutionContext&) const; virtual ResultOr<Value> evaluate(ExecutionContext&) const
{
return Result { SQLCommand::Unknown, SQLErrorCode::NotYetImplemented };
}
}; };
class ErrorExpression final : public Expression { class ErrorExpression final : public Expression {

5
Userland/Libraries/LibSQL/AST/Expression.cpp
View file

@ -12,11 +12,6 @@ namespace SQL::AST {
static const String s_posix_basic_metacharacters = ".^$*[]+\\"; static const String s_posix_basic_metacharacters = ".^$*[]+\\";
ResultOr<Value> Expression::evaluate(ExecutionContext&) const
{
return Value::null();
}
ResultOr<Value> NumericLiteral::evaluate(ExecutionContext&) const ResultOr<Value> NumericLiteral::evaluate(ExecutionContext&) const
{ {
Value ret(SQLType::Float); Value ret(SQLType::Float);