RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-27 11:57:35 +00:00
Code Issues Activity Actions

LibPDF: Avoid reading fields from moved-from Data object

Browse source 
This might not be an issue at the moment, but moved-from objects are
usually in a unspecifed but valid state, meaning that we shouldn't read
from them.
This commit is contained in:
Rodrigo Tobar 2023-01-07 21:27:46 +08:00 • committed by Andreas Kling
parent bfeca4ebb3
commit e751ec2089
2 changed files with 2 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Userland/Libraries/LibPDF/Fonts/TrueTypeFont.cpp
View file

@ -40,7 +40,7 @@ PDFErrorOr<NonnullRefPtr<PDFFont>> TrueTypeFont::create(Document* document, Nonn
TrueTypeFont::TrueTypeFont(PDFFont::CommonData data) TrueTypeFont::TrueTypeFont(PDFFont::CommonData data)
: m_data(data) : m_data(data)
{ {
m_is_standard_font = data.is_standard_font; m_is_standard_font = m_data.is_standard_font;
} }
u32 TrueTypeFont::char_code_to_code_point(u16 char_code) const u32 TrueTypeFont::char_code_to_code_point(u16 char_code) const

2
Userland/Libraries/LibPDF/Fonts/Type1Font.cpp
View file

@ -49,7 +49,7 @@ PDFErrorOr<NonnullRefPtr<Type1Font>> Type1Font::create(Document* document, Nonnu
Type1Font::Type1Font(Data data) Type1Font::Type1Font(Data data)
: m_data(move(data)) : m_data(move(data))
{ {
m_is_standard_font = data.is_standard_font; m_is_standard_font = m_data.is_standard_font;
} }
u32 Type1Font::char_code_to_code_point(u16 char_code) const u32 Type1Font::char_code_to_code_point(u16 char_code) const