RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 13:57:34 +00:00
Code Issues Activity Actions

LibWeb: Delete navigation id check in navigate_to_a_javascript_url

Browse source 
Adding this check was a mistake because although the navigation id
changes to null in step 2, it still has to proceed and apply the
history step.
This commit is contained in:
Aliaksandr Kalenik 2023-09-13 23:32:26 +02:00 • committed by Andreas Kling
parent f01cbaf5fb
commit ead311eac7
1 changed files with 0 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

4
Userland/Libraries/LibWeb/HTML/Navigable.cpp
View file

@ -1320,10 +1320,6 @@ WebIDL::ExceptionOr<void> Navigable::navigate_to_a_javascript_url(AK::URL const&
// 13. Append session history traversal steps to targetNavigable's traversable to finalize a cross-document navigation with targetNavigable, historyHandling, and historyEntry. // 13. Append session history traversal steps to targetNavigable's traversable to finalize a cross-document navigation with targetNavigable, historyHandling, and historyEntry.
traversable_navigable()->append_session_history_traversal_steps([this, history_entry, history_handling, navigation_id] { traversable_navigable()->append_session_history_traversal_steps([this, history_entry, history_handling, navigation_id] {
if (this->ongoing_navigation() != navigation_id) {
// NOTE: This check is not in the spec but we should not continue navigation if ongoing navigation id has changed.
return;
}
finalize_a_cross_document_navigation(*this, history_handling, history_entry); finalize_a_cross_document_navigation(*this, history_handling, history_entry);
}); });