RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-31 07:08:10 +00:00
Code Issues Activity Actions

LibWeb: Fix <body> and <img> elements not parsing their class attribute

Browse source 
Subclasses that override Element::parse_attribute() must always call to
base class since otherwise we might forget to parse some attributes.

This makes class selectors work on <body> and <img> elements. :^)
This commit is contained in:
Andreas Kling 2020-06-04 16:04:52 +02:00
parent 5be613c9c8
commit ec1891837f
2 changed files with 2 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

1
Libraries/LibWeb/DOM/HTMLBodyElement.cpp
View file

@ -60,6 +60,7 @@ void HTMLBodyElement::apply_presentational_hints(StyleProperties& style) const
void HTMLBodyElement::parse_attribute(const FlyString& name, const String& value) void HTMLBodyElement::parse_attribute(const FlyString& name, const String& value)
{ {
HTMLElement::parse_attribute(name, value);
if (name.equals_ignoring_case("link")) { if (name.equals_ignoring_case("link")) {
auto color = Color::from_string(value); auto color = Color::from_string(value);
if (color.has_value()) if (color.has_value())

1
Libraries/LibWeb/DOM/HTMLImageElement.cpp
View file

@ -48,6 +48,7 @@ HTMLImageElement::~HTMLImageElement()
void HTMLImageElement::parse_attribute(const FlyString& name, const String& value) void HTMLImageElement::parse_attribute(const FlyString& name, const String& value)
{ {
HTMLElement::parse_attribute(name, value);
if (name.equals_ignoring_case("src")) if (name.equals_ignoring_case("src"))
load_image(value); load_image(value);
} }