RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 04:17:34 +00:00
Code Issues Activity Actions

LibJS: Fix reference leak in ASTNode::append()

Browse source 
Using make<T> like this would create an unadopted object whose refcount
would never reach zero.
This commit is contained in:
Andreas Kling 2020-03-19 11:02:20 +01:00
parent d013753f83
commit f0b49ae04b
1 changed files with 1 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Libraries/LibJS/AST.h
View file

@ -87,7 +87,7 @@ public:
template<typename T, typename... Args> template<typename T, typename... Args>
T& append(Args&&... args) T& append(Args&&... args)
{ {
auto child = make<T>(forward<Args>(args)...); auto child = create_ast_node<T>(forward<Args>(args)...);
m_children.append(move(child)); m_children.append(move(child));
return static_cast<T&>(m_children.last()); return static_cast<T&>(m_children.last());
} }