RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 21:37:35 +00:00
Code Issues Activity Actions

LibWeb/MimeSniff: Remove unnecessary addition in mp4 signature match

Browse source 
A little whoopsie I did not see in 3aaa1c1. This is not erroneous
behavior, but it's just not necessary.
This commit is contained in:
Kemal Zebari 2024-01-12 17:00:56 -08:00 • committed by Andrew Kaster
parent ccd701809f
commit f2c1130f23
1 changed files with 3 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

6
Userland/Libraries/LibWeb/MimeSniff/Resource.cpp
View file

@ -151,9 +151,9 @@ bool matches_mp4_signature(ReadonlyBytes sequence)
// 4. Let box-size be the four bytes from sequence[0] to sequence[3], interpreted as a 32-bit unsigned big-endian integer.
u32 box_size = 0;
box_size |= static_cast<u32>(sequence[0] << 24);
box_size |= box_size + static_cast<u32>(sequence[1] << 16);
box_size |= box_size + static_cast<u32>(sequence[2] << 8);
box_size |= box_size + sequence[3];
box_size |= static_cast<u32>(sequence[1] << 16);
box_size |= static_cast<u32>(sequence[2] << 8);
box_size |= sequence[3];
// 5. If length is less than box-size or if box-size modulo 4 is not equal to 0, return false.
if ((length < box_size) || (box_size % 4 != 0))