RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-28 01:37:35 +00:00
Code Issues Activity Actions

LibJS: Increase margin in check for stack space limit

Browse source 
test-js crashes with a segmentation fault when running on macOS on Arm.
Increasing the margin in the test in did_reach_stack_space_limit() to
32 * KiB makes the tests pass. To simplify the code, this is applied
independently of platform, and the previous test for use of an address
sanitizer is removed.
This commit is contained in:
Morten Larsen 2022-01-20 13:35:55 +01:00 • committed by Idan Horowitz
parent 2ed4e47300
commit f71584b917
1 changed files with 2 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

6
Userland/Libraries/LibJS/Runtime/VM.h
View file

@ -83,11 +83,9 @@ public:
bool did_reach_stack_space_limit() const
{
#ifdef HAS_ADDRESS_SANITIZER
// Address sanitizer (ASAN) used to check for more space but
// currently we can't detect the stack size with it enabled.
return m_stack_info.size_free() < 32 * KiB;
#else
return m_stack_info.size_free() < 16 * KiB;
#endif
}
ThrowCompletionOr<void> push_execution_context(ExecutionContext& context, GlobalObject& global_object)