RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-31 05:38:11 +00:00
Code Issues Activity Actions

Kernel/Storage: Remove redundant reference to a controller in IDEChannel

Browse source 
IDEChannel which is an ATAPort derived class holded a NonnullRefPtr to a
parent IDEController, although we can easily defer the usage of it to
not be in the IDEChannel code at all, so it allows to keep NonnullRefPtr
to the parent ATAController in the ATAPort base class and only there.
This commit is contained in:
Liav A 2021-11-29 22:10:40 +02:00 • committed by Linus Groh
parent 0810c1b972
commit f96e8e97e6
2 changed files with 0 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Kernel/Storage/ATA/GenericIDE/Channel.cpp
View file

@ -122,7 +122,6 @@ UNMAP_AFTER_INIT IDEChannel::IDEChannel(IDEController const& controller, u8 irq,
, IRQHandler(irq)
, m_channel_type(type)
, m_io_group(io_group)
, m_parent_controller(controller)
{
}
@ -131,7 +130,6 @@ UNMAP_AFTER_INIT IDEChannel::IDEChannel(IDEController const& controller, IOAddre
, IRQHandler(type == ChannelType::Primary ? PATA_PRIMARY_IRQ : PATA_SECONDARY_IRQ)
, m_channel_type(type)
, m_io_group(io_group)
, m_parent_controller(controller)
{
}