RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-21 18:55:07 +00:00
Code Issues Activity Actions

DynamicLoader: Stop performing relative relocations on non-pie objects

Browse source 
Co-authored-by: Daniel Bertalan <dani@danielbertalan.dev>
This commit is contained in:
Idan Horowitz 2022-07-10 03:13:11 +03:00 • committed by Andreas Kling
parent b700d1a474
commit fbeef409c6
1 changed files with 2 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Userland/Libraries/LibELF/DynamicLoader.cpp
View file

@ -557,6 +557,8 @@ DynamicLoader::RelocationResult DynamicLoader::do_relocation(const ELF::DynamicO
#else #else
case R_X86_64_RELATIVE: { case R_X86_64_RELATIVE: {
#endif #endif
if (!image().is_dynamic())
break;
// FIXME: According to the spec, R_386_relative ones must be done first. // FIXME: According to the spec, R_386_relative ones must be done first.
// We could explicitly do them first using m_number_of_relocations from DT_RELCOUNT // We could explicitly do them first using m_number_of_relocations from DT_RELCOUNT
// However, our compiler is nice enough to put them at the front of the relocations for us :) // However, our compiler is nice enough to put them at the front of the relocations for us :)