RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-10-31 04:12:43 +00:00
Code Issues Activity Actions

AK: Make string-to-number conversion helpers return Optional

Browse source 
Get rid of the weird old signature:

- int StringType::to_int(bool& ok) const

And replace it with sensible new signature:

- Optional<int> StringType::to_int() const
This commit is contained in:
Andreas Kling 2020-06-12 21:07:52 +02:00
parent 15f4043a7a
commit fdfda6dec2
55 changed files with 354 additions and 455 deletions
Download patch file Download diff file Expand all files Collapse all files

5
AK/FlyString.cpp
View file

@ -26,6 +26,7 @@
#include <AK/FlyString.h>
#include <AK/HashTable.h>
#include <AK/Optional.h>
#include <AK/String.h>
#include <AK/StringUtils.h>
#include <AK/StringView.h>
@ -88,9 +89,9 @@ FlyString::FlyString(const char* string)
{
}
int FlyString::to_int(bool& ok) const
Optional<int> FlyString::to_int() const
{
return StringUtils::convert_to_int(view(), ok);
return StringUtils::convert_to_int(view());
}
bool FlyString::equals_ignoring_case(const StringView& other) const