RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-18 10:05:07 +00:00
Code Issues Activity Actions
49786 commits 1 branch 0 tags 227 MiB
Commit graph

36 commits

Author SHA1 Message Date
huttongrabiel
ad5abc9a8f DisplaySettings: Use FileSystemAccessServer instead of FilePicker 
Make a call to the FileSystemAccessServer instead of using FilePicker to
select a new wallpaper in BackgroundSettings.
 2023-04-09 18:19:57 -06:00
implicitfield
44b67db7ab DisplaySettings: Stop using DeprecatedString 
This also further improves error propagation in cases where String
demands it.
 2023-03-21 10:06:41 +01:00
implicitfield
1c20cf7bee DisplaySettings: Propagate errors in BackgroundSettingsWidget 2023-03-21 10:06:41 +01:00
Julian Offenhäuser
ab5b61c3fe DisplaySettings: Capitalize fallback display mode when loading settings 
This setting was capitalized a while ago, except for this place where
we fall back to "[C]center". This caused a crash in MonitorWidget.
 2023-02-10 15:41:56 +01:00
Marcus Nilsson
feef83359d DisplaySettings: Made select wallpaper use allowed file types 2023-02-02 04:05:42 -07:00
Tim Schumacher
82a152b696 LibGfx: Remove try_ prefix from bitmap creation functions 
Those don't have any non-try counterpart, so we might as well just omit
it.
 2023-01-26 20:24:37 +00:00
Sam Atkins
f0395a2042 LibGUI+Userland: Rename try_load_from_gml() -> load_from_gml() :^) 
It's the only one, so the `try` prefix is unnecessary now.
 2023-01-07 14:39:30 +01:00
Sam Atkins
54b1326165 Userland: Replace all uses of load_from_gml with try_load_from_gml 
MOAR FIXMES! ;^)
 2023-01-07 14:39:30 +01:00
Linus Groh
57dc179b1f Everywhere: Rename to_{string => deprecated_string}() where applicable 
This will make it easier to support both string types at the same time
while we convert code, and tracking down remaining uses.

One big exception is Value::to_string() in LibJS, where the name is
dictated by the ToString AO.
 2022-12-06 08:54:33 +01:00
Linus Groh
6e19ab2bbc AK+Everywhere: Rename String to DeprecatedString 
We have a new, improved string type coming up in AK (OOM aware, no null
state), and while it's going to use UTF-8, the name UTF8String is a
mouthful - so let's free up the String name by renaming the existing
class.
Making the old one have an annoying name will hopefully also help with
quick adoption :^)
 2022-12-06 08:54:33 +01:00
Timothy Flynn
4fd9e3ab08 Userland: Remove workarounds for LibIPC include order sensitivity 2022-11-15 13:25:51 -05:00
networkException
4230dbbb21 AK+Everywhere: Replace "protocol" with "scheme" url helpers 
URL had properly named replacements for protocol(), set_protocol() and
create_with_file_protocol() already. This patch removes these function
and updates all call sites to use the functions named according to the
specification.

See https://url.spec.whatwg.org/#concept-url-scheme
 2022-09-29 09:39:04 +01:00
James Bellamy
352d6545a9 WindowServer+DisplaySettings: Capitalize display mode dropdown 
Every other dropdown in settings is capitalized apart from this one.
This commit fixes that.
 2022-08-24 12:17:30 +02:00
sin-ack
3f3f45580a Everywhere: Add sv suffix to strings relying on StringView(char const*) 
Each of these strings would previously rely on StringView's char const*
constructor overload, which would call __builtin_strlen on the string.
Since we now have operator ""sv, we can replace these with much simpler
versions. This opens the door to being able to remove
StringView(char const*).

No functional changes.
 2022-07-12 23:11:35 +02:00
Sam Atkins
d7190be3a3 DisplaySettings: Set window modified state 2022-05-12 13:10:49 +02:00
Karol Kosek
92f4408d66 DisplaySettings: Make the copy action copy the background path as url 
Closes: #13907
 2022-05-08 16:41:04 +02:00
Ben Maxwell
8070a98288 DisplaySettings+WindowServer: Allow updating theme without background 
With this change you can now set the theme and background color at the
same time in the Display Settings. Before if both were changed
before hitting 'apply' the theme background color would overwrite
the custom background.
 2022-04-03 12:58:46 +02:00
Itamar
935d023967 Userland: Rename WindowServerConnection=>ConnectionToWindowServer 
This was done with CLion's automatic rename feature.
 2022-02-25 22:35:12 +01:00
Sam Atkins
8260135d4d LibCore+Everywhere: Return ErrorOr from ConfigFile factory methods 
I've attempted to handle the errors gracefully where it was clear how to
do so, and simple, but a lot of this was just adding
`release_value_but_fixme_should_propagate_errors()` in places.
 2022-02-16 19:49:41 -05:00
Lenny Maiorani
160bda7228 Applications: Use default constructors/destructors 
https://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines#cother-other-default-operation-rules

"The compiler is more likely to get the default semantics right and
you cannot implement these functions better than the compiler."
 2022-02-14 22:06:55 +00:00
James Puleo
a0e7a4b9a8 WindowServer+Userland: Pass wallpapers as Gfx::Bitmap instead of path 
The WindowServer _really_ does not need to know the filesystem path to
it's wallpaper, and allows setting arbitrary wallpapers (those outside
of `/res/wallpapers`).

The GUI::Desktop will keep track of the path to the wallpaper (if any),
and save it to config if desired (to be persisted).

This avoids the need to `unveil` paths to the wallpaper, fixing #11158
 2022-02-14 16:38:42 +03:30
Karol Kosek
20191b58e2 DisplaySettings: Update wallpaper config path only on success 
The Window Server is ignoring incorrect files since 235f39e449, so let's
not update the config when that happens and an error message instead!
 2021-11-26 11:30:55 -08:00
Karol Kosek
e56ffd11ce DisplaySettings: Always save the background color to the config 
Previously, you could notice that the background color isn't being
updated when you picked a small bitmap image with the 'center' mode.
 2021-11-26 11:30:55 -08:00
Andreas Kling
235f39e449 LibGfx: Use ErrorOr<T> for Bitmap::try_load_from_file() 
This was used in a lot of places, so this patch makes liberal use of
ErrorOr<T>::release_value_but_fixme_should_propagate_errors().
 2021-11-08 00:35:27 +01:00
Karol Kosek
ad5bd209ba DisplaySettings: Add context menu for wallpapers 
This adds a 'Show in File Manager' action and copy path action to file
context menu for quicker navigation. :^)
 2021-09-03 23:15:47 +02:00
Mustafa Quraish
8fdb435d24 DisplaySettings: Use LibConfig where possible 
Some places here still need to open `/etc/WindowServer.ini` which
we can't do with th ConfigServer yet.
 2021-08-31 17:00:41 +02:00
networkException
acde7d12b0 Everywhere: Rename get in ConfigFile::get_for_{lib,app,system} to open 
This patch brings the ConfigFile helpers for opening lib, app and system
configs more inline with the regular ConfigFile::open functions.
 2021-08-22 01:32:25 +02:00
networkException
938051feb8 Everywhere: Use Core::ConfigFile::AllowWriting::Yes to allow writing 2021-08-22 01:32:25 +02:00
Karol Kosek
e8fad5614e DisplaySettings: Pass the parent window to the FilePicker 
Prior this change, closing the Display Settings application
didn't close the File Picker.
 2021-08-14 15:20:21 +02:00
Karol Kosek
e2ad59ce06 DisplaySettings: Remove the trailing dot from tooltip and window title 2021-08-14 15:20:21 +02:00
Karol Kosek
4d477824e0 DisplaySettings: Open the wallpaper file picker in the wallpaper path 
This small change can indirectly tell you where wallpapers are saved.
 2021-08-14 15:20:21 +02:00
Andreas Kling
93ef661914 WindowServer+DisplaySettings: Remove the weird "simple" wallpaper mode 
Painting the wallpaper at 100% scale in the top left corner is a weird
mode and I don't think we need it. :^)
 2021-05-20 17:52:38 +02:00
Andreas Kling
6394ea00d8 DisplaySettings: Remove icon from browse-for-wallpaper button 
The icon on this button looked out of place.
 2021-05-20 00:13:56 +02:00
Andreas Kling
7f206ca6de DisplaySettings: Select the currently used wallpaper on startup 2021-05-20 00:03:30 +02:00
Andreas Kling
bb9e955ef8 DisplaySettings: Make MonitorWidget update itself on property changes 2021-05-20 00:03:30 +02:00
Andreas Kling
540acc1a32 DisplaySettings: Give the UI a facelift :^) 
- Split the main UI into two tabs: "Background" and "Monitor".
- Use a GUI::IconView for selecting background pictures.
- Tweak layout, spacing, etc.
 2021-05-20 00:03:30 +02:00