1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-25 22:05:07 +00:00
Commit graph

49316 commits

Author SHA1 Message Date
Matthew Olsson
bad541a0d4 LibWeb: Remove outdated FIXMEs around WebIDL::invoke_callback usages 2023-04-17 10:27:40 +02:00
Matthew Olsson
c40109628d LibWeb: Properly reject abrupt completion in clean_up_on_return 2023-04-17 10:27:40 +02:00
Kenneth Myhra
4ed71d5b40 Ports: Add depends 'libslirp' and configopt '--enable-slirp' to QEMU
This adds the dependency 'libslirp' and forces QEMU to pick up the
dependency or fail compilation by adding the config option
'enable-slirp'.
2023-04-17 10:19:28 +02:00
Kenneth Myhra
ae075b3dff Ports: Reformat QEMU's package.sh script
Use single quotes for non-interpolated strings in the 'configopts' and
'depends' sections.
Let each dependency of the 'depends' section be on a separate line.
2023-04-17 10:19:28 +02:00
Kenneth Myhra
4e661a400b Ports: Add libslirp version 4.7.0
The slirp submodule was removed from QEMU in version 7.2, running
Serenity in QEMU on a Serenity host could fail without this one if
running with network enabled.

For more information on the removal of the slirp submodule see the
following link: https://wiki.qemu.org/ChangeLog/7.2#Removal_of_the_%22slirp%22_submodule_(affects_%22-netdev_user%22)
2023-04-17 10:19:28 +02:00
MacDue
f0dde6236d Tests: Add layout test for SVG preserveAspectRatio
This is a cut down version of the example, but it's nice to add a
test to ensure this keeps working.
2023-04-17 07:32:31 +02:00
MacDue
71ed1e3e50 Base: Add SVG preserveAspectRatio demo page 2023-04-17 07:32:31 +02:00
MacDue
5df4e64eb7 LibWeb: Implement SVG preserveAspectRatio attribute
This attribute is used to define how the viewBox should be scaled.
Previously the behaviour implemented was that of "xMidYMid meet", now
all of them work (expect none :P).

With this the Discord login backend is now correctly scaled/positioned.

This also brings our SVG code a little closer to the spec! With spec
comments and all :^)

(Minor non-visible update to layout tests)
2023-04-17 07:32:31 +02:00
MacDue
5a12e9f222 LibWeb: Clip SVG content to parent <svg> element bounding box 2023-04-17 07:32:31 +02:00
Tim Schumacher
d4e114a31e Kernel: Remove unused functions related to reading full inodes 2023-04-17 01:20:23 +02:00
Tim Schumacher
f5010f7263 Kernel: Use purpose-sized buffers for holding readlink results 2023-04-17 01:20:23 +02:00
Tim Schumacher
6f524e35a7 Kernel: Use purpose-sized buffers when resolving inodes as links 2023-04-17 01:20:23 +02:00
Tim Schumacher
acd8c8dba4 Kernel: Add Inode::read_until_filled_or_end
The existing `read_entire` is quite slow due to allocating and copying
multiple times, but it is simultaneously quite hard to get rid of in a
single step. As a replacement, add a new function that reads as much as
possible directly into a user-provided buffer.
2023-04-17 01:20:23 +02:00
Timothy Flynn
c403f8e92c LibWeb: Update the media playback time for clicks on the media timeline
When clicking on the media timeline, compute the percentage along the
timeline's width the user clicked, and set the playback time to the same
percentage of the video's duration.
2023-04-17 01:16:04 +02:00
Timothy Flynn
ad3c63684c LibWeb: Restrict toggling video playback to certain areas in a video
When the control bar is shown, do not toggle playback when clicking on
the control bar, unless the click target is the playback button. This
will let us implement clicking on the timeline to seek.

Note that this requires caching some layout rects on the video element.
We need to remember where the corresponding layout boxes are, and we
can't cache them on the layout box, as that may be destroyed any time.
2023-04-17 01:16:04 +02:00
Timothy Flynn
c4e3ba2dfb LibWeb: Implement converting a DevicePixelRect to a CSSPixelRect
Which also requires converting a DevicePixelSize to a CSSPixelSize.
2023-04-17 01:16:04 +02:00
Timothy Flynn
5a98a5529f LibWeb: Begin implementing media resource seeking 2023-04-17 01:16:04 +02:00
Timothy Flynn
f8f35fdaad LibVideo: Remove hook to notify clients upon reaching end of the stream
This reverts commit 33047b38ec.

This use case is now satisfied with on_playback_state_change and getting
the playback state from the PlaybackManager.
2023-04-17 01:16:04 +02:00
Timothy Flynn
6cd50d1910 LibWeb: Change the callback used to detect the end of a video stream
The on_end_of_stream callback was added to notify clients that video
playback has stopped when we didn't have a way to retrieve the playback
state from Video::PlaybackManager. Now that we do, we should consolidate
on using the on_playback_state_change callback to detect such changes.
2023-04-17 01:16:04 +02:00
Timothy Flynn
c08755836d LibWeb: Fix a couple of HTMLMediaElement spec links 2023-04-17 01:16:04 +02:00
Nico Weber
4aaefeb1d5 Meta: Move some flags to common_compile_options.cmake
No behavior change.
2023-04-17 00:52:21 +02:00
Andreas Kling
e7f5b5a2f3 LibWeb: Fix multi-line flex column layouts with auto height on container
When sizing a flex container with flex-direction:column under a
max-content height constraint, we were incorrectly truncating the
infinite available height to 0 when collecting flex items into lines.

This caused us to put every flex item in its own flex line, which is the
complete opposite of what we want during max-content intrinsic sizing,
as the layout would grow wide but not tall.
2023-04-16 21:45:15 +02:00
Andreas Kling
b9b6037d2b LibWeb: Honor gap between flex lines when using align-content: stretch
We have to take the cross gap into account when calculating the "sum of
flex line cross sizes" in "Handle 'align-content: stretch'".
2023-04-16 20:52:32 +02:00
Kenneth Myhra
f488df0e10 Ports: Update GLib to 2.76.1 2023-04-16 08:49:08 +01:00
Tim Schumacher
f7ac121ac4 Meta: Allow overriding the calculated disk image inode count 2023-04-15 19:41:08 -07:00
Tim Schumacher
e887989c23 Meta: Add missing quotation marks for INODE_COUNT and INODE_SIZE 2023-04-15 19:41:08 -07:00
MacDue
f9c61e3ba7 LibWeb: Scale SVG stroke-width based on viewbox
This fixes the clipping of strokes in quite a few cases and now fixes
the Gartic Phone logo :^)

(Layout test updated but no visible changes there)
2023-04-15 19:28:13 +02:00
Linus Groh
cb79c6bc2f Ports: Add xz to Python dependencies
This makes it build the `_lzma` module, and thus makes `lzma` work.

Thanks to hjalves for the suggestion!
2023-04-15 18:30:24 +02:00
Linus Groh
960b55dd7d Ports: Update Python to 3.11.3
Released on 2023-04-05.
https://www.python.org/downloads/release/python-3113/
2023-04-15 18:10:49 +02:00
Linus Groh
8d3e941ae6 Toolchain: Add imagemagick to serenity.nix
This is required to install ports with a launcher icon.
2023-04-15 18:10:49 +02:00
Linus Groh
fd35fc5ba8 LibWeb/Fetch: Fix build error in HeadersIterator::next()
Regressed in d4eaaf9.
2023-04-15 16:49:37 +02:00
Linus Groh
d4eaaf905c LibJS: Port create_iterator_result_object() to NonnullGCPtr 2023-04-15 16:26:42 +02:00
Linus Groh
aff1ec6014 LibJS: Port iterator_step() to GCPtr 2023-04-15 16:23:03 +02:00
Linus Groh
e54536421a LibJS: Port iterator_next() to NonnullGCPtr 2023-04-15 16:22:57 +02:00
Linus Groh
b110258848 LibJS: Port this_symbol_value() to NonnullGCPtr 2023-04-15 16:06:52 +02:00
Linus Groh
dd91f1a5a5 LibJS: Port this_string_value() to NonnullGCPtr 2023-04-15 16:06:18 +02:00
Linus Groh
9c6eba771a LibJS: Port this_bigint_value() to NonnullGCPtr 2023-04-15 16:06:02 +02:00
Linus Groh
d8ee4c0e7d LibJS: Add remaining missing spec comments to StringPrototype
The changes from ac2f109 were from an old branch, which either had a
rebase accident or was simply incomplete. Should be complete now :^)
2023-04-15 16:00:59 +02:00
Stanisław Wiśniewski
1649138a29 LibC: Return nullptr if allocation fails in strdup() and strndup()
If allocation would fail, we would continue to UB at memcpy
and nullptr dereference before returning.
2023-04-15 15:38:24 +02:00
thankyouverycool
cfac3be0b3 LibGUI: Resize Label on font changes
And set fixed preferred heights when autosizing.
2023-04-15 15:24:50 +02:00
thankyouverycool
5294ef918e LibGUI: Implement calculated_min_size() for Label 2023-04-15 15:24:50 +02:00
thankyouverycool
479e67212a LibGUI: Implement calculated_min_size() for DialogButton
Dialog buttons now scale based on presentation size to accomodate
larger fonts while retaining uniform widths. Scaling by 8 is
arbitrary but preserves the historical 80 pixel width with Katica 10.
This needs improvement but works well for most fonts as a start.
2023-04-15 15:24:50 +02:00
thankyouverycool
5181fafce6 LibGUI: Improve calculated_min_size() for Button
Previously min_width() was fixed, rendering width calculations in
calculated_min_size() useless for layout. Minimum width now shrinks
to 22, the historical minimum for height as well, and takes into
account elided text and icons. Height no longer sums the icon, fixing
a layout regression for icon buttons.

Also removes an unnecessary FIXME: Calculated size should only
need to account for the height of a single line of elided text
plus padding. Font's pixel_size_rounded_up() is the right solution
even though it and the underlying pixel metrics of some ScaledFonts
don't always correspond yet.
2023-04-15 15:24:50 +02:00
thankyouverycool
55423b4ed0 LibGfx+Userland: Add width_rounded_up() helper 2023-04-15 15:24:50 +02:00
thankyouverycool
c9404c3a63 LibGUI+Userland: Convert MessageBox to fallible construction
Adds fallible versions of MessageBox's helper factories, ports
DeprecatedString, and rewrites build() to be both fallible and
more responsive to font changes.

MessageBox now auto shrinks and no longer has to re-build its
layout when text changes. It is manually resized once at
creation to position properly as a Dialog before being shown.
2023-04-15 15:24:50 +02:00
thankyouverycool
aa94b944de LibGUI: Allow Windows to auto shrink
Previously Windows automatically grew to accomodate layout changes
when obeying minimum widget size but would not automatically shrink
if so desired. Setting auto shrink true now automatically resizes
windows to their effective_min_size() every time their minimum size
updates. This will be useful for making fixed size windows responsive
to layout and font changes in the future.
2023-04-15 15:24:50 +02:00
Linus Groh
ac2f1098f7 LibJS: Add spec comments to StringPrototype 2023-04-15 14:07:28 +02:00
Linus Groh
16197af60d LibJS: Add spec comments to StringObject 2023-04-15 14:07:28 +02:00
Linus Groh
9cf1a244f8 LibJS: Add spec comments to ProxyConstructor 2023-04-15 14:07:28 +02:00
Linus Groh
b1ea436093 LibJS: Add spec comments to ObjectPrototype 2023-04-15 14:07:28 +02:00